RESOLVED FIXED 23697
Leaks seen on Worker tests 
https://bugs.webkit.org/show_bug.cgi?id=23697
Summary Leaks seen on Worker tests
Alexey Proskuryakov
Reported 2009-02-02 14:01:12 PST
See e.g. <http://build.webkit.org/results/trunk-mac-intel-debug/5945/DumpRenderTree2-leaks.txt>. I have a fix, patch forthcoming.
Attachments
proposed fix (1.25 KB, patch)
2009-02-02 14:06 PST, Alexey Proskuryakov 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2009-02-02 14:06:11 PST
Created attachment 27260 [details] proposed fix The issue turned out to be much simpler than I thought.
David Levin
Comment 2 2009-02-02 14:31:28 PST
Interesting. Looks good to me (but I'm not a reviewer so it doesn't matter). The key thing to note is that workerContextDestroyedInternal may get called due to a posted task before the worker object is destroyed. Then when the worker object is destroyed later, it should call workerContextDestroyedInternal(); to do the final clean up. One issue the comment in WorkerMessagingProxy::workerObjectDestroyed() workerContextDestroyedInternal(); // It never existed, just do our cleanup. isn't really accurate anymore. Really, the worker thread no longer exists at this point.
Darin Adler
Comment 3 2009-02-02 14:40:17 PST
Comment on attachment 27260 [details] proposed fix r=me
Alexey Proskuryakov
Comment 4 2009-02-02 22:40:01 PST
Committed revision 40523. I've removed the obsolete comment - thanks Dave!
Note You need to log in before you can comment on or make changes to this bug.