Bug 236953 - css/css-grid/subgrid/orthogonal-writing-mode-002/4
Summary: css/css-grid/subgrid/orthogonal-writing-mode-002/4
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks: 202115
  Show dependency treegraph
 
Reported: 2022-02-20 23:10 PST by Matt Woodrow
Modified: 2022-03-01 00:56 PST (History)
10 users (show)

See Also:


Attachments
Patch (4.19 KB, patch)
2022-02-21 16:34 PST, Matt Woodrow
no flags Details | Formatted Diff | Diff
Patch (5.49 KB, patch)
2022-02-28 13:58 PST, Matt Woodrow
no flags Details | Formatted Diff | Diff
Patch (5.49 KB, patch)
2022-02-28 16:00 PST, Matt Woodrow
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (5.49 KB, patch)
2022-02-28 16:22 PST, Matt Woodrow
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2022-02-20 23:10:38 PST
In these case, it looks like the expected file (which doesn't use subgrid) are the ones rendering incorrectly.
Comment 1 Radar WebKit Bug Importer 2022-02-21 11:19:32 PST
<rdar://problem/89246997>
Comment 2 Matt Woodrow 2022-02-21 16:34:30 PST
Created attachment 452795 [details]
Patch
Comment 3 Dean Jackson 2022-02-21 17:11:54 PST
Comment on attachment 452795 [details]
Patch

Assuming the bots get another crack at this after the WebGPU breakage is cleared...
Comment 4 Oriol Brufau 2022-02-28 07:16:41 PST
Comment on attachment 452795 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452795&action=review

> Source/WebCore/rendering/RenderBox.cpp:3637
> +    LayoutUnit availableHeight = (isHorizontalWritingMode() == containingBlock()->isHorizontalWritingMode()) ? containingBlockLogicalHeightForContent(heightType) : containingBlockLogicalWidthForContent();

Nit: you can use isOrthogonal(*this, *containingBlock())
Comment 5 Matt Woodrow 2022-02-28 13:58:58 PST
Created attachment 453423 [details]
Patch
Comment 6 Matt Woodrow 2022-02-28 16:00:56 PST
Created attachment 453445 [details]
Patch
Comment 7 Matt Woodrow 2022-02-28 16:22:37 PST
Created attachment 453448 [details]
Patch
Comment 8 EWS 2022-03-01 00:56:24 PST
Committed r290634 (247907@main): <https://commits.webkit.org/247907@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453448 [details].