Bug 236910 - [WebGPU] Tracer bullet part 10: Implement setLabel() and Metal accessors
Summary: [WebGPU] Tracer bullet part 10: Implement setLabel() and Metal accessors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 236879
  Show dependency treegraph
 
Reported: 2022-02-19 21:39 PST by Myles C. Maxfield
Modified: 2022-02-21 13:33 PST (History)
3 users (show)

See Also:


Attachments
Patch (16.73 KB, patch)
2022-02-19 21:41 PST, Myles C. Maxfield
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2022-02-19 21:39:28 PST
By adding a few various trivial functions in classes that need them, this patch completely finishes the implementation of CommandBuffer, QuerySet, RenderBundle, Sampler, and TextureView classes (other than their creation functions).
Comment 1 Myles C. Maxfield 2022-02-19 21:41:10 PST
Created attachment 452678 [details]
Patch
Comment 2 Dean Jackson 2022-02-21 09:35:48 PST
Comment on attachment 452678 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452678&action=review

> Source/WebGPU/WebGPU/RenderPassEncoder.mm:178
> +    m_renderCommandEncoder.label = [NSString stringWithCString:label encoding:NSUTF8StringEncoding];

Do you ever want to ASSERT that m_renderCommandEncoder etc exist?
Comment 3 Myles C. Maxfield 2022-02-21 13:31:08 PST
Comment on attachment 452678 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452678&action=review

>> Source/WebGPU/WebGPU/RenderPassEncoder.mm:178
>> +    m_renderCommandEncoder.label = [NSString stringWithCString:label encoding:NSUTF8StringEncoding];
> 
> Do you ever want to ASSERT that m_renderCommandEncoder etc exist?

Yep! It's done in the creation routines. And rather than ASSERT()ing, it instead just doesn't create the WebGPU wrapper object.
Comment 4 Myles C. Maxfield 2022-02-21 13:32:51 PST
Committed r290266 (247591@trunk): <https://commits.webkit.org/247591@trunk>
Comment 5 Radar WebKit Bug Importer 2022-02-21 13:33:31 PST
<rdar://problem/89253939>