By adding a few various trivial functions in classes that need them, this patch completely finishes the implementation of CommandBuffer, QuerySet, RenderBundle, Sampler, and TextureView classes (other than their creation functions).
Created attachment 452678 [details] Patch
Comment on attachment 452678 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452678&action=review > Source/WebGPU/WebGPU/RenderPassEncoder.mm:178 > + m_renderCommandEncoder.label = [NSString stringWithCString:label encoding:NSUTF8StringEncoding]; Do you ever want to ASSERT that m_renderCommandEncoder etc exist?
Comment on attachment 452678 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452678&action=review >> Source/WebGPU/WebGPU/RenderPassEncoder.mm:178 >> + m_renderCommandEncoder.label = [NSString stringWithCString:label encoding:NSUTF8StringEncoding]; > > Do you ever want to ASSERT that m_renderCommandEncoder etc exist? Yep! It's done in the creation routines. And rather than ASSERT()ing, it instead just doesn't create the WebGPU wrapper object.
Committed r290266 (247591@trunk): <https://commits.webkit.org/247591@trunk>
<rdar://problem/89253939>