RESOLVED FIXED Bug 236909
[GPU Process] [iOS] Text decoration is always drawn with solid stroke style 
https://bugs.webkit.org/show_bug.cgi?id=236909
Summary [GPU Process] [iOS] Text decoration is always drawn with solid stroke style
Jon Lee
Reported 2022-02-19 21:39:21 PST
fast/css3-text/css3-text-decoration/text-decoration-dashed.html [ ImageOnlyFailure ] fast/css3-text/css3-text-decoration/text-decoration-dotted-dashed.html [ ImageOnlyFailure ] fast/css3-text/css3-text-decoration/text-decoration-dotted.html [ ImageOnlyFailure ] fast/css3-text/css3-text-decoration/text-underline-style.html [ ImageOnlyFailure ]
Attachments
Patch (15.35 KB, patch)
2022-03-31 14:01 PDT, Said Abou-Hallawa 		simon.fraser: review+
DetailsFormatted DiffDiff
Patch (15.87 KB, patch)
2022-03-31 14:35 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-02-19 21:39:58 PST
<rdar://problem/89196615>
Said Abou-Hallawa
Comment 2 2022-03-31 14:01:41 PDT
Created attachment 456277 [details] Patch
Simon Fraser (smfr)
Comment 3 2022-03-31 14:10:22 PDT
Comment on attachment 456277 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456277&action=review > Source/WebCore/platform/graphics/displaylists/DisplayListItems.h:937 > + StrokeStyle m_style; This is currently 4 bytes. Might as well change `enum StrokeStyle` to `enum StrokeStyle : uint8_t` while you're at it.
Said Abou-Hallawa
Comment 4 2022-03-31 14:35:48 PDT
Created attachment 456283 [details] Patch
EWS
Comment 5 2022-03-31 17:29:55 PDT
Committed r292190 (249093@main): <https://commits.webkit.org/249093@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456283 [details].
Note You need to log in before you can comment on or make changes to this bug.