Bug 236909 - [GPU Process] [iOS] Text decoration is always drawn with solid stroke style
Summary: [GPU Process] [iOS] Text decoration is always drawn with solid stroke style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Process Model (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 233914 236508
  Show dependency tree / graph
 
Reported: 2022-02-19 21:39 PST by Jon Lee
Modified: 2022-05-13 15:14 PDT (History)
5 users (show)

See Also:

Attachments
Patch (15.35 KB, patch)
2022-03-31 14:01 PDT, Said Abou-Hallawa 		simon.fraser: review+
Details | Formatted Diff | Diff
Patch (15.87 KB, patch)
2022-03-31 14:35 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2022-02-19 21:39:21 PST 
fast/css3-text/css3-text-decoration/text-decoration-dashed.html [ ImageOnlyFailure ]
fast/css3-text/css3-text-decoration/text-decoration-dotted-dashed.html [ ImageOnlyFailure ]
fast/css3-text/css3-text-decoration/text-decoration-dotted.html [ ImageOnlyFailure ]
fast/css3-text/css3-text-decoration/text-underline-style.html [ ImageOnlyFailure ]
Comment 1 Radar WebKit Bug Importer 2022-02-19 21:39:58 PST 
<rdar://problem/89196615>
Comment 2 Said Abou-Hallawa 2022-03-31 14:01:41 PDT 
Created attachment 456277 [details]
Patch
Comment 3 Simon Fraser (smfr) 2022-03-31 14:10:22 PDT 
Comment on attachment 456277 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456277&action=review

> Source/WebCore/platform/graphics/displaylists/DisplayListItems.h:937
> +    StrokeStyle m_style;

This is currently 4 bytes. Might as well change `enum StrokeStyle` to `enum StrokeStyle : uint8_t` while you're at it.
Comment 4 Said Abou-Hallawa 2022-03-31 14:35:48 PDT 
Created attachment 456283 [details]
Patch
Comment 5 EWS 2022-03-31 17:29:55 PDT 
Committed r292190 (249093@main): <https://commits.webkit.org/249093@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456283 [details].