Bug 236903 - [WebGPU] Tracer bullet part 9: Basic implementation of bindings
Summary: [WebGPU] Tracer bullet part 9: Basic implementation of bindings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 236879
  Show dependency treegraph
 
Reported: 2022-02-19 20:59 PST by Myles C. Maxfield
Modified: 2022-02-21 13:28 PST (History)
3 users (show)

See Also:


Attachments
Patch (22.31 KB, patch)
2022-02-19 21:00 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (22.31 KB, text/plain)
2022-02-19 21:04 PST, Myles C. Maxfield
no flags Details
Patch (22.32 KB, patch)
2022-02-19 21:09 PST, Myles C. Maxfield
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2022-02-19 20:59:22 PST
This is a basic implementation of the BindGroup, BindGroupLayout, and PipelineLayout methods. Eventually we'll want to suballocate multiple BindGroups so they coexist within the same Buffer, but this is an initial simple implementation that doesn't do that.
Comment 1 Myles C. Maxfield 2022-02-19 21:00:48 PST
Created attachment 452670 [details]
Patch
Comment 2 Myles C. Maxfield 2022-02-19 21:04:11 PST
Created attachment 452671 [details]
Patch
Comment 3 Myles C. Maxfield 2022-02-19 21:09:23 PST
Created attachment 452675 [details]
Patch
Comment 4 Dean Jackson 2022-02-21 09:33:34 PST
Comment on attachment 452675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452675&action=review

> Source/WebGPU/WebGPU/BindGroup.h:48
> +    id <MTLBuffer> vertexArgumentBuffer() const { return m_vertexArgumentBuffer; }
> +    id <MTLBuffer> fragmentArgumentBuffer() const { return m_fragmentArgumentBuffer; }
> +    id <MTLBuffer> computeArgumentBuffer() const { return m_computeArgumentBuffer; }

id<MTLBuffer> no space. Here and elsewhere.
Comment 5 Myles C. Maxfield 2022-02-21 13:28:01 PST
Committed r290264 (?): <https://commits.webkit.org/r290264>
Comment 6 Myles C. Maxfield 2022-02-21 13:28:05 PST
Comment on attachment 452675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452675&action=review

>> Source/WebGPU/WebGPU/BindGroup.h:48
>> +    id <MTLBuffer> computeArgumentBuffer() const { return m_computeArgumentBuffer; }
> 
> id<MTLBuffer> no space. Here and elsewhere.

I sent an email to webkit-dev about this. Let's see what people say, and then I'll add a rule to the style guide about it.
Comment 7 Radar WebKit Bug Importer 2022-02-21 13:28:18 PST
<rdar://problem/89253636>