This is a basic implementation of the BindGroup, BindGroupLayout, and PipelineLayout methods. Eventually we'll want to suballocate multiple BindGroups so they coexist within the same Buffer, but this is an initial simple implementation that doesn't do that.
Created attachment 452670 [details] Patch
Created attachment 452671 [details] Patch
Created attachment 452675 [details] Patch
Comment on attachment 452675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452675&action=review > Source/WebGPU/WebGPU/BindGroup.h:48 > + id <MTLBuffer> vertexArgumentBuffer() const { return m_vertexArgumentBuffer; } > + id <MTLBuffer> fragmentArgumentBuffer() const { return m_fragmentArgumentBuffer; } > + id <MTLBuffer> computeArgumentBuffer() const { return m_computeArgumentBuffer; } id<MTLBuffer> no space. Here and elsewhere.
Committed r290264 (?): <https://commits.webkit.org/r290264>
Comment on attachment 452675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452675&action=review >> Source/WebGPU/WebGPU/BindGroup.h:48 >> + id <MTLBuffer> computeArgumentBuffer() const { return m_computeArgumentBuffer; } > > id<MTLBuffer> no space. Here and elsewhere. I sent an email to webkit-dev about this. Let's see what people say, and then I'll add a rule to the style guide about it.
<rdar://problem/89253636>