Bug 236902 - [WebGPU] Tracer bullet part 8: Basic implementation of device creation routines
Summary: [WebGPU] Tracer bullet part 8: Basic implementation of device creation routines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 236879
  Show dependency tree / graph
 
Reported: 2022-02-19 20:32 PST by Myles C. Maxfield
Modified: 2022-02-21 12:50 PST (History)
3 users (show)

See Also:

Attachments
Patch (11.65 KB, patch)
2022-02-19 20:34 PST, Myles C. Maxfield 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2022-02-19 20:32:54 PST 
This is a basic implementation of the Instance, Adapter, and Device methods. Device limits are not implemented yet, so for now we claim every limits is 0.
Comment 1 Myles C. Maxfield 2022-02-19 20:34:33 PST 
Created attachment 452668 [details]
Patch
Comment 2 Dean Jackson 2022-02-21 09:29:41 PST 
Comment on attachment 452668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452668&action=review

> Source/WebGPU/ChangeLog:9
> +        implemented yet, so for now we claim every limits is 0.

typo: limits

> Source/WebGPU/WebGPU/Adapter.mm:63
> +    properties->driverDescription = "";

Not emptyString()?
Comment 3 Myles C. Maxfield 2022-02-21 12:49:11 PST 
Committed r290262 (?): <https://commits.webkit.org/r290262>
Comment 4 Radar WebKit Bug Importer 2022-02-21 12:50:22 PST 
<rdar://problem/89251773>