Bug 236898 - [WebGPU] Tracer bullet part 5: Give Metal objects to WebGPU objects
Summary: [WebGPU] Tracer bullet part 5: Give Metal objects to WebGPU objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on: 236891
Blocks: 236879
  Show dependency tree / graph
 
Reported: 2022-02-19 16:24 PST by Myles C. Maxfield
Modified: 2022-02-21 11:33 PST (History)
3 users (show)

See Also:

Attachments
Patch (38.24 KB, patch)
2022-02-19 16:26 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (38.36 KB, patch)
2022-02-19 20:17 PST, Myles C. Maxfield 		dino: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2022-02-19 16:24:06 PST 
Each WebGPU object gets its own backing Metal object.
Comment 1 Myles C. Maxfield 2022-02-19 16:26:13 PST 
Created attachment 452662 [details]
Patch
Comment 2 Myles C. Maxfield 2022-02-19 20:17:39 PST 
Created attachment 452667 [details]
Patch
Comment 3 Dean Jackson 2022-02-21 09:23:50 PST 
Comment on attachment 452667 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452667&action=review

> Source/WebGPU/WebGPU/BindGroup.h:53
> +    id <MTLBuffer> m_vertexArgumentBuffer { nil };
> +    id <MTLBuffer> m_fragmentArgumentBuffer { nil };
> +    id <MTLBuffer> m_computeArgumentBuffer { nil };
>  };

I think we do id<MTLBuffer> (without the space), here and elsewhere.
Comment 4 Myles C. Maxfield 2022-02-21 11:28:50 PST 
Comment on attachment 452667 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452667&action=review

>> Source/WebGPU/WebGPU/BindGroup.h:53
>>  };
> 
> I think we do id<MTLBuffer> (without the space), here and elsewhere.

I polled the Apple L&R team internally and they seemed to prefer id <MTLBuffer>, so that's what I went with :/
Comment 5 Myles C. Maxfield 2022-02-21 11:32:41 PST 
Committed r290256 (?): <https://commits.webkit.org/r290256>
Comment 6 Radar WebKit Bug Importer 2022-02-21 11:33:18 PST 
<rdar://problem/89247804>