Bug 236871 - Optimize DOM storage event dispatch
Summary: Optimize DOM storage event dispatch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 236985
  Show dependency tree / graph
 
Reported: 2022-02-18 16:13 PST by Chris Dumez
Modified: 2022-02-21 10:56 PST (History)
11 users (show)

See Also:

Attachments
Patch (36.86 KB, patch)
2022-02-18 16:18 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (36.82 KB, patch)
2022-02-19 12:34 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (36.57 KB, patch)
2022-02-19 20:42 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-02-18 16:13:43 PST 
Optimize DOM storage event dispatch.
Comment 1 Chris Dumez 2022-02-18 16:18:03 PST 
Created attachment 452601 [details]
Patch
Comment 2 Chris Dumez 2022-02-19 12:34:56 PST 
Created attachment 452650 [details]
Patch
Comment 3 Sihui Liu 2022-02-19 20:19:41 PST 
Comment on attachment 452650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452650&action=review

r=me

> Source/WebCore/storage/StorageEventDispatcher.cpp:55
> +        if (!frame->document() || !frame->window())
>              continue;
> -        if (sourceFrame != frame && frame->document()->securityOrigin().equal(securityOrigin.securityOrigin().ptr()))
> -            frames.append(frame);
> +        if (!frame->window()->hasEventListeners(eventNames().storageEvent))

window() also checks document(). maybe something like:
if (auto* window = frame->window(); !window || !window->hasEventListeners(eventNames().storageEvent)) continue;

> Source/WebCore/storage/StorageEventDispatcher.cpp:77
> +            if (!frame->document() || !frame->window())
> +                continue;
> +            if (!frame->window()->hasEventListeners(eventNames().storageEvent))

Ditto.
Comment 4 Chris Dumez 2022-02-19 20:35:55 PST 
(In reply to Sihui Liu from comment #3)
> Comment on attachment 452650 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=452650&action=review
> 
> r=me

No r+? :)

> > Source/WebCore/storage/StorageEventDispatcher.cpp:55
> > +        if (!frame->document() || !frame->window())
> >              continue;
> > -        if (sourceFrame != frame && frame->document()->securityOrigin().equal(securityOrigin.securityOrigin().ptr()))
> > -            frames.append(frame);
> > +        if (!frame->window()->hasEventListeners(eventNames().storageEvent))
> 
> window() also checks document(). maybe something like:
> if (auto* window = frame->window(); !window ||
> !window->hasEventListeners(eventNames().storageEvent)) continue;
> 
> > Source/WebCore/storage/StorageEventDispatcher.cpp:77
> > +            if (!frame->document() || !frame->window())
> > +                continue;
> > +            if (!frame->window()->hasEventListeners(eventNames().storageEvent))
> 
> Ditto.
Comment 5 Chris Dumez 2022-02-19 20:42:01 PST 
Created attachment 452669 [details]
Patch
Comment 6 Chris Dumez 2022-02-19 20:42:42 PST 
(In reply to Chris Dumez from comment #4)
> (In reply to Sihui Liu from comment #3)
> > Comment on attachment 452650 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=452650&action=review
> > 
> > r=me
> 
> No r+? :)
> 
> > > Source/WebCore/storage/StorageEventDispatcher.cpp:55
> > > +        if (!frame->document() || !frame->window())
> > >              continue;
> > > -        if (sourceFrame != frame && frame->document()->securityOrigin().equal(securityOrigin.securityOrigin().ptr()))
> > > -            frames.append(frame);
> > > +        if (!frame->window()->hasEventListeners(eventNames().storageEvent))
> > 
> > window() also checks document(). maybe something like:
> > if (auto* window = frame->window(); !window ||
> > !window->hasEventListeners(eventNames().storageEvent)) continue;
> > 
> > > Source/WebCore/storage/StorageEventDispatcher.cpp:77
> > > +            if (!frame->document() || !frame->window())
> > > +                continue;
> > > +            if (!frame->window()->hasEventListeners(eventNames().storageEvent))
> > 
> > Ditto.

Thanks for reviewing, I made the suggested changes.
Comment 7 Sihui Liu 2022-02-19 20:51:38 PST 
(In reply to Chris Dumez from comment #6)
> (In reply to Chris Dumez from comment #4)
> > (In reply to Sihui Liu from comment #3)
> > > Comment on attachment 452650 [details]
> > > Patch
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=452650&action=review
> > > 
> > > r=me
> > 
> > No r+? :)

r+

> > 
> > > > Source/WebCore/storage/StorageEventDispatcher.cpp:55
> > > > +        if (!frame->document() || !frame->window())
> > > >              continue;
> > > > -        if (sourceFrame != frame && frame->document()->securityOrigin().equal(securityOrigin.securityOrigin().ptr()))
> > > > -            frames.append(frame);
> > > > +        if (!frame->window()->hasEventListeners(eventNames().storageEvent))
> > > 
> > > window() also checks document(). maybe something like:
> > > if (auto* window = frame->window(); !window ||
> > > !window->hasEventListeners(eventNames().storageEvent)) continue;
> > > 
> > > > Source/WebCore/storage/StorageEventDispatcher.cpp:77
> > > > +            if (!frame->document() || !frame->window())
> > > > +                continue;
> > > > +            if (!frame->window()->hasEventListeners(eventNames().storageEvent))
> > > 
> > > Ditto.
> 
> Thanks for reviewing, I made the suggested changes.
Comment 8 EWS 2022-02-19 23:13:40 PST 
Committed r290223 (247549@main): <https://commits.webkit.org/247549@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452669 [details].
Comment 9 Radar WebKit Bug Importer 2022-02-19 23:14:17 PST 
<rdar://problem/89197481>