Bug 236869 - [JSC] Make ArrayPrototype just an array
Summary: [JSC] Make ArrayPrototype just an array
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on: 236890
Blocks:
  Show dependency treegraph
 
Reported: 2022-02-18 16:11 PST by Yusuke Suzuki
Modified: 2022-06-23 16:54 PDT (History)
9 users (show)

See Also:


Attachments
Patch (3.33 KB, patch)
2022-02-18 16:13 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (3.38 KB, patch)
2022-02-18 16:16 PST, Yusuke Suzuki
saam: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2022-02-18 16:11:58 PST
[JSC] Make ArrayPrototype just an array
Comment 1 Yusuke Suzuki 2022-02-18 16:13:09 PST
Created attachment 452598 [details]
Patch
Comment 2 Yusuke Suzuki 2022-02-18 16:14:12 PST
This makes RuntimeArray only DerivedArray. Once RuntimeArray is removed, we can just remove DerivedArray.
Comment 3 Yusuke Suzuki 2022-02-18 16:16:29 PST
Created attachment 452599 [details]
Patch
Comment 4 Yusuke Suzuki 2022-02-18 19:53:20 PST
Committed r290194 (247522@trunk): <https://commits.webkit.org/247522@trunk>
Comment 5 Radar WebKit Bug Importer 2022-02-18 19:54:36 PST
<rdar://problem/89178074>
Comment 6 Yusuke Suzuki 2022-02-19 09:52:10 PST
Committed r290210 (?): <https://commits.webkit.org/r290210>
Comment 7 WebKit Commit Bot 2022-02-19 13:13:23 PST
Re-opened since this is blocked by bug 236890
Comment 8 Brent Fulgham 2022-06-23 16:54:48 PDT
Closing this bug, as the optimization approach seemed to have some drawbacks.