Bug 236866 - [LFC][IFC] Introduce LineBoxBuilder::collectFallbackFonts
Summary: [LFC][IFC] Introduce LineBoxBuilder::collectFallbackFonts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-18 15:46 PST by zalan
Modified: 2022-02-19 05:32 PST (History)
5 users (show)

See Also:

Attachments
Patch (8.15 KB, patch)
2022-02-18 15:51 PST, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (8.14 KB, patch)
2022-02-18 21:59 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-02-18 15:46:36 PST 
This is in preparation for supporting ideographic baseline
Comment 1 zalan 2022-02-18 15:51:54 PST 
Created attachment 452591 [details]
Patch
Comment 2 Antti Koivisto 2022-02-18 21:50:07 PST 
Comment on attachment 452591 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452591&action=review

> Source/WebCore/layout/formattingContexts/inline/text/TextUtil.h:58
> +    static FallbackFontList fallbackFontsForText(const StringView&, const RenderStyle&, IncludeHyphen);

const StringView& is bit pointless, it is better used as a value type (it is just pointer and a length)
Comment 3 zalan 2022-02-18 21:54:07 PST 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 452591 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=452591&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/text/TextUtil.h:58
> > +    static FallbackFontList fallbackFontsForText(const StringView&, const RenderStyle&, IncludeHyphen);
> 
> const StringView& is bit pointless, it is better used as a value type (it is
> just pointer and a length)
Oh you are right. it's muscle memory.
Comment 4 zalan 2022-02-18 21:59:41 PST 
Created attachment 452625 [details]
[fast-cq]Patch
Comment 5 EWS 2022-02-19 05:31:38 PST 
Committed r290204 (247532@main): <https://commits.webkit.org/247532@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452625 [details].
Comment 6 Radar WebKit Bug Importer 2022-02-19 05:32:18 PST 
<rdar://problem/89186091>