Bug 236866 – [LFC][IFC] Introduce LineBoxBuilder::collectFallbackFonts

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

This is in preparation for supporting ideographic baseline

[zalan]

Created attachment 452591 [details]
Patch

[Antti Koivisto]

Comment on attachment 452591 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452591&action=review

> Source/WebCore/layout/formattingContexts/inline/text/TextUtil.h:58
> +    static FallbackFontList fallbackFontsForText(const StringView&, const RenderStyle&, IncludeHyphen);

const StringView& is bit pointless, it is better used as a value type (it is just pointer and a length)

[zalan]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 452591 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=452591&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/text/TextUtil.h:58
> > +    static FallbackFontList fallbackFontsForText(const StringView&, const RenderStyle&, IncludeHyphen);
> 
> const StringView& is bit pointless, it is better used as a value type (it is
> just pointer and a length)
Oh you are right. it's muscle memory.

[zalan]

Created attachment 452625 [details]
[fast-cq]Patch

[EWS]

Committed r290204 (247532@main): <https://commits.webkit.org/247532@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452625 [details].

[Radar WebKit Bug Importer]

<rdar://problem/89186091>