Bug 236835 - [LFC][Integration] Add missing LineIteratorModernPath::isHorizontal implementation
Summary: [LFC][Integration] Add missing LineIteratorModernPath::isHorizontal implement...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-18 05:02 PST by zalan
Modified: 2022-02-18 08:33 PST (History)
5 users (show)

See Also:


Attachments
Patch (10.46 KB, patch)
2022-02-18 05:05 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-02-18 05:02:14 PST
ssia
Comment 1 zalan 2022-02-18 05:05:17 PST
Created attachment 452511 [details]
Patch
Comment 2 Antti Koivisto 2022-02-18 05:10:21 PST
Comment on attachment 452511 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452511&action=review

> Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLine.h:80
> +    bool m_isHorizontal { true };

This might not really need a bit since it is always same for all lines within a block?
Comment 3 zalan 2022-02-18 05:12:37 PST
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 452511 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=452511&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLine.h:80
> > +    bool m_isHorizontal { true };
> 
> This might not really need a bit since it is always same for all lines
> within a block?
Yeah, we should definitely come back to it when all the vertical modes are enabled and see if we could just grab it off of the IFC root.
Comment 4 EWS 2022-02-18 08:32:14 PST
Committed r290127 (247471@main): <https://commits.webkit.org/247471@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452511 [details].
Comment 5 Radar WebKit Bug Importer 2022-02-18 08:33:18 PST
<rdar://problem/89146753>