RESOLVED FIXED 236835
[LFC][Integration] Add missing LineIteratorModernPath::isHorizontal implementation 
https://bugs.webkit.org/show_bug.cgi?id=236835
Summary [LFC][Integration] Add missing LineIteratorModernPath::isHorizontal implement...
zalan
Reported 2022-02-18 05:02:14 PST
ssia
Attachments
Patch (10.46 KB, patch)
2022-02-18 05:05 PST, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2022-02-18 05:05:17 PST
Created attachment 452511 [details] Patch
Antti Koivisto
Comment 2 2022-02-18 05:10:21 PST
Comment on attachment 452511 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452511&action=review > Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLine.h:80 > + bool m_isHorizontal { true }; This might not really need a bit since it is always same for all lines within a block?
zalan
Comment 3 2022-02-18 05:12:37 PST
(In reply to Antti Koivisto from comment #2) > Comment on attachment 452511 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452511&action=review > > > Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLine.h:80 > > + bool m_isHorizontal { true }; > > This might not really need a bit since it is always same for all lines > within a block? Yeah, we should definitely come back to it when all the vertical modes are enabled and see if we could just grab it off of the IFC root.
EWS
Comment 4 2022-02-18 08:32:14 PST
Committed r290127 (247471@main): <https://commits.webkit.org/247471@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452511 [details].
Radar WebKit Bug Importer
Comment 5 2022-02-18 08:33:18 PST
<rdar://problem/89146753>
Note You need to log in before you can comment on or make changes to this bug.