Bug 236823 – Use async NSSharingServicePicker menu if available

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Kate Cheney]

Use async sharingServicePicker menu if available

[Kate Cheney]

Created attachment 452477 [details]
Patch

[Kate Cheney]

rdar://88858606

[Dean Jackson]

Comment on attachment 452477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452477&action=review

> Source/WebKit/UIProcess/Cocoa/WKShareSheet.h:45
> +- (void)showPickerAsync:(NSSharingServicePicker *)picker showRelativeToRect:(NSRect)presentationRect ofView:(WKWebView *)webView completion:(void (^)(void))completionHandler;
>  @property (nonatomic, weak) id <WKShareSheetDelegate> delegate;

Nit: I think we usually put a blank line between the methods and the @property(s).

[Dean Jackson]

Comment on attachment 452477 [details]
Patch

It seems NSSharingServicePicker is an unknown type.

[Kate Cheney]

(In reply to Dean Jackson from comment #4)
> Comment on attachment 452477 [details]
> Patch
> 
> It seems NSSharingServicePicker is an unknown type.

Oops, I think the SPI is Mac only, need to add some #if PLATFORM(MAC) tags. And then mac failures are because I changed the function but didn't update the non-internal-sdk declarations. New patch coming

[Kate Cheney]

(In reply to Dean Jackson from comment #3)
> Comment on attachment 452477 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=452477&action=review
> 
> > Source/WebKit/UIProcess/Cocoa/WKShareSheet.h:45
> > +- (void)showPickerAsync:(NSSharingServicePicker *)picker showRelativeToRect:(NSRect)presentationRect ofView:(WKWebView *)webView completion:(void (^)(void))completionHandler;
> >  @property (nonatomic, weak) id <WKShareSheetDelegate> delegate;
> 
> Nit: I think we usually put a blank line between the methods and the
> @property(s).

Will fix in new patch!

[Kate Cheney]

Created attachment 452530 [details]
Patch

[Kate Cheney]

Created attachment 452533 [details]
Patch

[EWS]

Committed r290173 (247504@main): <https://commits.webkit.org/247504@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452533 [details].