Bug 236806 - Refactor share menu item presentation
Summary: Refactor share menu item presentation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kate Cheney
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-17 14:46 PST by Kate Cheney
Modified: 2022-02-17 18:32 PST (History)
5 users (show)

See Also:

Attachments
Patch (5.41 KB, patch)
2022-02-17 15:02 PST, Kate Cheney 		no flags Details | Formatted Diff | Diff
Patch (5.34 KB, patch)
2022-02-17 15:55 PST, Kate Cheney 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kate Cheney 2022-02-17 14:46:32 PST 
Refactor share menu item presentation
Comment 1 Kate Cheney 2022-02-17 15:02:02 PST 
Created attachment 452436 [details]
Patch
Comment 2 Kate Cheney 2022-02-17 15:03:31 PST Comment hidden (obsolete)
Comment 3 Kate Cheney 2022-02-17 15:04:20 PST 
rdar://problem/88858606
Comment 4 Aditya Keerthi 2022-02-17 15:20:45 PST 
Comment on attachment 452436 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452436&action=review

> Source/WebCore/PAL/pal/spi/mac/NSSharingServicePickerSPI.h:31
> +@interface NSSharingServicePicker (Internal)

Nit: "Staging" is a more accurate name for the category.

> Source/WebCore/PAL/pal/spi/mac/NSSharingServicePickerSPI.h:-44
> -- (void)getMenuWithCompletion:(void(^)(NSMenu *))completion;

I think this deletion will cause open source builds to fail, `getMenuWithCompletion:` is still used in `WebContextMenuProxyMac`.
Comment 5 Megan Gardner 2022-02-17 15:21:50 PST 
Comment on attachment 452436 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452436&action=review

> Source/WebCore/PAL/pal/spi/mac/NSSharingServicePickerSPI.h:32
> +- (NSMenuItem *)standardShareMenuItem;

Staging_rdarNumber to be specific
Comment 6 Kate Cheney 2022-02-17 15:23:23 PST 
Comment on attachment 452436 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452436&action=review

thanks for the review!

>> Source/WebCore/PAL/pal/spi/mac/NSSharingServicePickerSPI.h:32
>> +- (NSMenuItem *)standardShareMenuItem;
> 
> Staging_rdarNumber to be specific

will fix!

>> Source/WebCore/PAL/pal/spi/mac/NSSharingServicePickerSPI.h:-44
>> -- (void)getMenuWithCompletion:(void(^)(NSMenu *))completion;
> 
> I think this deletion will cause open source builds to fail, `getMenuWithCompletion:` is still used in `WebContextMenuProxyMac`.

Ah you're right, this is leftover from a previous iteration.
Comment 7 Kate Cheney 2022-02-17 15:55:22 PST 
Created attachment 452442 [details]
Patch
Comment 8 EWS 2022-02-17 18:32:34 PST 
Committed r290103 (247449@main): <https://commits.webkit.org/247449@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452442 [details].