isAXAuthenticatedCallback in WebProcess Cocoa performs IPC to the UI process to determine if the given auditToken is valid. This causes a crash with isolated tree mode enabled as IPC must be performed on the main thread / runloop. We should dispatch to the main runloop in this function.
<rdar://problem/89094972>
Created attachment 452385 [details] Patch
Comment on attachment 452385 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452385&action=review > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:229 > + WebProcess::singleton().parentProcessConnection()->sendSync(Messages::WebProcessProxy::IsAXAuthenticated(auditToken), Messages::WebProcessProxy::IsAXAuthenticated::Reply(authenticated), 0); can we cache this? why do we need to keep checking this?
(In reply to chris fleizach from comment #3) > Comment on attachment 452385 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452385&action=review > > > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:229 > > + WebProcess::singleton().parentProcessConnection()->sendSync(Messages::WebProcessProxy::IsAXAuthenticated(auditToken), Messages::WebProcessProxy::IsAXAuthenticated::Reply(authenticated), 0); > > can we cache this? why do we need to keep checking this? It's requested very infrequently, once per AX client that tries to talk to the web process, so I don't think caching would be beneficial.
Committed r290128 (247472@main): <https://commits.webkit.org/247472@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452385 [details].