Bug 236770 - [GTK] Build broken with ENABLE_X11_TARGET=OFF and no X11 headers present
Summary: [GTK] Build broken with ENABLE_X11_TARGET=OFF and no X11 headers present
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-17 04:22 PST by Adrian Perez
Modified: 2022-02-17 09:20 PST (History)
15 users (show)

See Also:


Attachments
Patch (1.95 KB, patch)
2022-02-17 04:37 PST, Adrian Perez
no flags Details | Formatted Diff | Diff
Patch for landing (2.01 KB, patch)
2022-02-17 07:12 PST, Adrian Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2022-02-17 04:22:36 PST
In file included from ../Source/ThirdParty/ANGLE/include/EGL/egl.h:39,
                 from ../Source/ThirdParty/ANGLE/src/common/PackedEGLEnums_autogen.h,
                 from ../Source/ThirdParty/ANGLE/src/common/PackedEnums.h:12,
                 from ../Source/ThirdParty/ANGLE/src/common/PackedEnums.cpp:9:
../Source/ThirdParty/ANGLE/include/EGL/eglplatform.h:128:10: fatal error: X11/Xlib.h: No such file or directory
  128 | #include <X11/Xlib.h>
      |          ^~~~~~~~~~~~
Comment 1 Adrian Perez 2022-02-17 04:24:24 PST
There's the same issue in the 2.34.x releases, tested with the current
state of the stable release branch.
Comment 2 Adrian Perez 2022-02-17 04:37:29 PST
Created attachment 452350 [details]
Patch
Comment 3 EWS Watchlist 2022-02-17 04:39:21 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 Alejandro G. Castro 2022-02-17 04:55:58 PST
Comment on attachment 452350 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452350&action=review

LGTM! Thanks!

> Source/ThirdParty/ANGLE/ChangeLog:8
> +        * PlatformGTK.cmake: The USE_SYSTEM_EGL definition makes detaches the type definitions

I guess 'makes' is a leftover.
Comment 5 Adrian Perez 2022-02-17 05:01:35 PST
(In reply to Alejandro G. Castro from comment #4)
> Comment on attachment 452350 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=452350&action=review
> 
> LGTM! Thanks!
> 
> > Source/ThirdParty/ANGLE/ChangeLog:8
> > +        * PlatformGTK.cmake: The USE_SYSTEM_EGL definition makes detaches the type definitions
> 
> I guess 'makes' is a leftover.

Indeed it's a grammar mistake. I'll fix this before landing the patch, thanks!
Comment 6 Adrian Perez 2022-02-17 07:12:08 PST
Created attachment 452363 [details]
Patch for landing
Comment 7 EWS 2022-02-17 09:19:24 PST
Committed r290027 (247407@main): <https://commits.webkit.org/247407@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452363 [details].
Comment 8 Radar WebKit Bug Importer 2022-02-17 09:20:18 PST
<rdar://problem/89090769>