Bug 236767 – Multiple concurrency violations in LibWebRTCCodecsProxy

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[Kimmo Kinnunen]

Multiple concurrency violations in LibWebRTCCodecsProxy

[Kimmo Kinnunen]

<rdar://88904160>

[Kimmo Kinnunen]

Created attachment 452342 [details]
Patch

[Kimmo Kinnunen]

Created attachment 452512 [details]
Patch

[Dean Jackson]

Comment on attachment 452512 [details]
Patch

Removing r? flag - it's already been reviewed by Antti. It looks like this is an EWS/landing test.

[Kimmo Kinnunen]

Created attachment 453090 [details]
Patch for landing

[Kimmo Kinnunen]

Created attachment 453197 [details]
Patch for landing

[EWS]

Tools/Scripts/svn-apply failed to apply attachment 453197 [details] to trunk.
Please resolve the conflicts and upload a new patch.

[Kimmo Kinnunen]

Created attachment 453289 [details]
Patch for landing

[EWS]

Committed r290547 (?): <https://commits.webkit.org/r290547>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453289 [details].

[youenn fablet]

Comment on attachment 453289 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=453289&action=review

> Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:281
> +        ASSERT_IS_TESTING_IPC();

This is a new ASSERT that is currently hit in bots, I'll fix it.

[Kimmo Kinnunen]

(In reply to youenn fablet from comment #10)
> Comment on attachment 453289 [details]
> Patch for landing
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=453289&action=review
> 
> > Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:281
> > +        ASSERT_IS_TESTING_IPC();
> 
> This is a new ASSERT that is currently hit in bots, I'll fix it.

Thanks, sorry for the trouble..