Bug 236753 – [macOS] Light appearance text fields are invisible in Increased Contrast mode

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Aditya Keerthi]

1. Set light appearance: System Preferences > General > Light.
2. Turn on Increased Contrast mode: System Preferences > Accessibility > Display > Increase contrast.
3. Visit https://whsieh.github.io/examples/forms.
4. Observe the lack of borders for text fields.

[Aditya Keerthi]

Created attachment 452321 [details]
Patch

[Aditya Keerthi]

Note: I am still discussing with the relevant teams to see if this can be fixed beneath WebKit in a reasonable time frame.

For now, this is the proposed workaround in WebKit.

[Wenson Hsieh]

Comment on attachment 452321 [details]
Patch

(In reply to Aditya Keerthi from comment #2)
> Note: I am still discussing with the relevant teams to see if this can be
> fixed beneath WebKit in a reasonable time frame.
> 
> For now, this is the proposed workaround in WebKit.

Sounds good to me — let's land this workaround if rdar://88948646 isn't going to be resolved in the system framework in time.

[Dean Jackson]

Comment on attachment 452321 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452321&action=review

> Source/WebCore/ChangeLog:12
> +        "borders only" text fields in Increased Constrast mode.

Typo: Constrast

> Source/WebCore/ChangeLog:19
> +        No new tests, as tests that change system preferences are often unreliable,
> +        and we do not have existing hooks to toggle Increased Constrast mode.

Couldn't we have an Internals feature that turns it on for a particular test? Similar to what we do for reduced motion?

[Aditya Keerthi]

(In reply to Dean Jackson from comment #4)
> Comment on attachment 452321 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=452321&action=review
> 
> > Source/WebCore/ChangeLog:12
> > +        "borders only" text fields in Increased Constrast mode.
> 
> Typo: Constrast
> 
> > Source/WebCore/ChangeLog:19
> > +        No new tests, as tests that change system preferences are often unreliable,
> > +        and we do not have existing hooks to toggle Increased Constrast mode.
> 
> Couldn't we have an Internals feature that turns it on for a particular
> test? Similar to what we do for reduced motion?

I think the Internals feature for reduced motion is read-only?

[Aditya Keerthi]

rdar://89093315

[Aditya Keerthi]

Created attachment 452380 [details]
[fast-cq] Patch for landing

[EWS]

Committed r290046 (247418@main): <https://commits.webkit.org/247418@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452380 [details].

[WebKit Commit Bot]

Re-opened since this is blocked by bug 236797

[Aditya Keerthi]

Created attachment 452410 [details]
[fast-cq] Patch

[EWS]

Committed r290052 (247422@main): <https://commits.webkit.org/247422@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452410 [details].

[WebKit Commit Bot]

Re-opened since this is blocked by bug 236799

[Aditya Keerthi]

Created attachment 452414 [details]
[fast-cq] Patch

[EWS]

Committed r290054 (247424@main): <https://commits.webkit.org/247424@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452414 [details].