Bug 236753 - [macOS] Light appearance text fields are invisible in Increased Contrast mode
Summary: [macOS] Light appearance text fields are invisible in Increased Contrast mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: Safari 14
Hardware: Unspecified macOS 11
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on: 236797 236799
Blocks:
  Show dependency treegraph
 
Reported: 2022-02-16 22:53 PST by Aditya Keerthi
Modified: 2022-02-17 12:42 PST (History)
15 users (show)

See Also:


Attachments
Patch (5.91 KB, patch)
2022-02-16 22:57 PST, Aditya Keerthi
no flags Details | Formatted Diff | Diff
[fast-cq] Patch for landing (5.93 KB, patch)
2022-02-17 10:03 PST, Aditya Keerthi
no flags Details | Formatted Diff | Diff
[fast-cq] Patch (5.96 KB, patch)
2022-02-17 12:24 PST, Aditya Keerthi
no flags Details | Formatted Diff | Diff
[fast-cq] Patch (5.96 KB, patch)
2022-02-17 12:36 PST, Aditya Keerthi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2022-02-16 22:53:37 PST
1. Set light appearance: System Preferences > General > Light.
2. Turn on Increased Contrast mode: System Preferences > Accessibility > Display > Increase contrast.
3. Visit https://whsieh.github.io/examples/forms.
4. Observe the lack of borders for text fields.
Comment 1 Aditya Keerthi 2022-02-16 22:57:30 PST
Created attachment 452321 [details]
Patch
Comment 2 Aditya Keerthi 2022-02-16 23:00:29 PST
Note: I am still discussing with the relevant teams to see if this can be fixed beneath WebKit in a reasonable time frame.

For now, this is the proposed workaround in WebKit.
Comment 3 Wenson Hsieh 2022-02-17 07:52:08 PST
Comment on attachment 452321 [details]
Patch

(In reply to Aditya Keerthi from comment #2)
> Note: I am still discussing with the relevant teams to see if this can be
> fixed beneath WebKit in a reasonable time frame.
> 
> For now, this is the proposed workaround in WebKit.

Sounds good to me — let's land this workaround if rdar://88948646 isn't going to be resolved in the system framework in time.
Comment 4 Dean Jackson 2022-02-17 08:03:16 PST
Comment on attachment 452321 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452321&action=review

> Source/WebCore/ChangeLog:12
> +        "borders only" text fields in Increased Constrast mode.

Typo: Constrast

> Source/WebCore/ChangeLog:19
> +        No new tests, as tests that change system preferences are often unreliable,
> +        and we do not have existing hooks to toggle Increased Constrast mode.

Couldn't we have an Internals feature that turns it on for a particular test? Similar to what we do for reduced motion?
Comment 5 Aditya Keerthi 2022-02-17 09:23:07 PST
(In reply to Dean Jackson from comment #4)
> Comment on attachment 452321 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=452321&action=review
> 
> > Source/WebCore/ChangeLog:12
> > +        "borders only" text fields in Increased Constrast mode.
> 
> Typo: Constrast
> 
> > Source/WebCore/ChangeLog:19
> > +        No new tests, as tests that change system preferences are often unreliable,
> > +        and we do not have existing hooks to toggle Increased Constrast mode.
> 
> Couldn't we have an Internals feature that turns it on for a particular
> test? Similar to what we do for reduced motion?

I think the Internals feature for reduced motion is read-only?
Comment 6 Aditya Keerthi 2022-02-17 09:59:00 PST
rdar://89093315
Comment 7 Aditya Keerthi 2022-02-17 10:03:21 PST
Created attachment 452380 [details]
[fast-cq] Patch for landing
Comment 8 EWS 2022-02-17 12:05:22 PST
Committed r290046 (247418@main): <https://commits.webkit.org/247418@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452380 [details].
Comment 9 WebKit Commit Bot 2022-02-17 12:16:54 PST
Re-opened since this is blocked by bug 236797
Comment 10 Aditya Keerthi 2022-02-17 12:24:56 PST
Created attachment 452410 [details]
[fast-cq] Patch
Comment 11 EWS 2022-02-17 12:29:13 PST
Committed r290052 (247422@main): <https://commits.webkit.org/247422@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452410 [details].
Comment 12 WebKit Commit Bot 2022-02-17 12:31:06 PST
Re-opened since this is blocked by bug 236799
Comment 13 Aditya Keerthi 2022-02-17 12:36:50 PST
Created attachment 452414 [details]
[fast-cq] Patch
Comment 14 EWS 2022-02-17 12:42:22 PST
Committed r290054 (247424@main): <https://commits.webkit.org/247424@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452414 [details].