Bug 236746 – WPEQtView is missing most features

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

If using WPEQtView, it seems that ( https://github.com/WebKit/WebKit/blob/main/Source/WebKit/UIProcess/API/wpe/qt/WPEQtView.h ) only a handful of methods/properties are available, comparing to WebKitWebView ( https://github.com/WebKit/WebKit/blob/main/Source/WebKit/UIProcess/API/wpe/WebKitWebView.h ). To make things worse, there is no way to retrieve the inner WebKitWebView either. This means I cannot use most of the features in WebKitWebView if I want to use WPEQtView.

Ideally, I should be able to use any WebKit public API within QML (meaning wrapping all the classes into QObjects). If that is unfeasible, we should at least provide API to construct with a user-provided WebKitWebView, and retrieve the one stored.

Created attachment 455417 [details]
Expose WebKitWebView in WPEQtView

[Philippe Normand]

LGTM but a ChangeLog is needed, see https://webkit.org/contributing-code/#changelog-files

Created attachment 455583 [details]
Expose WebKitWebView from WPEQtView (with changelog)

[Jonathan Bedard]

Marked the patch as "r?", since it seems that was Tusooa's intent.

[Adrian Perez]

Comment on attachment 455583 [details]
Expose WebKitWebView from WPEQtView (with changelog)

I think we could merge this, but could you please make the style
bot happy? If you want to check your commit locally, you can use
“Tools/Scripts/check-webkit-style -g @”

View in context: https://bugs.webkit.org/attachment.cgi?id=455583&action=review

> Source/WebKit/ChangeLog:11
> +        No new tests (OOPS!).

You need to remove this line, or rewrite it as “No new tests needed.”

Created attachment 456292 [details]
Expose WebKitWebView from WPEQtView

(In reply to Adrian Perez from comment #5)
> Comment on attachment 455583 [details]
> Expose WebKitWebView from WPEQtView (with changelog)
> 
> I think we could merge this, but could you please make the style
> bot happy? If you want to check your commit locally, you can use
> “Tools/Scripts/check-webkit-style -g @”
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=455583&action=review
> 
> > Source/WebKit/ChangeLog:11
> > +        No new tests (OOPS!).
> 
> You need to remove this line, or rewrite it as “No new tests needed.”

Thank you for suggesting the tool. It no longer complains with the patch I added just now.

[Adrian Perez]

(In reply to tusooa from comment #7)
> (In reply to Adrian Perez from comment #5)
> > Comment on attachment 455583 [details]
> > Expose WebKitWebView from WPEQtView (with changelog)
> > 
> > I think we could merge this, but could you please make the style
> > bot happy? If you want to check your commit locally, you can use
> > “Tools/Scripts/check-webkit-style -g @”
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=455583&action=review
> > 
> > > Source/WebKit/ChangeLog:11
> > > +        No new tests (OOPS!).
> > 
> > You need to remove this line, or rewrite it as “No new tests needed.”
> 
> Thank you for suggesting the tool. It no longer complains with the patch I
> added just now.

Thanks, patch approved. I'll wait that the bots are green before sending
it to the commit queue :)

[EWS]

ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.

[EWS]

Committed r292236 (249137@main): <https://commits.webkit.org/249137@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456292 [details].