Bug 236742 - [WebGPU] Add a playground example target
Summary: [WebGPU] Add a playground example target
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-16 17:11 PST by Myles C. Maxfield
Modified: 2022-02-17 13:33 PST (History)
3 users (show)

See Also:


Attachments
Patch (15.69 KB, patch)
2022-02-16 17:13 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (16.93 KB, patch)
2022-02-16 17:15 PST, Myles C. Maxfield
dino: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2022-02-16 17:11:23 PST
[WebGPU] Add a playground example target
Comment 1 Myles C. Maxfield 2022-02-16 17:13:40 PST
Created attachment 452274 [details]
Patch
Comment 2 Myles C. Maxfield 2022-02-16 17:15:45 PST
Created attachment 452275 [details]
Patch
Comment 3 Dean Jackson 2022-02-17 04:46:55 PST
Comment on attachment 452275 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452275&action=review

> Source/WebGPU/CommandLinePlayground/main.swift:29
> +autoreleasepool {

why does this have to be in an autoreleasepool?

> Source/WebGPU/CommandLinePlayground/main.swift:36
> +    var _ = WGPUTextureDescriptorViewFormats(chain: WGPUChainedStruct(next: nil, sType: WGPUSType(rawValue: WGPUSTypeExtended_TextureDescriptorViewFormats.rawValue)), viewFormatsCount: 0, viewFormats: nil)

let?
Comment 4 Myles C. Maxfield 2022-02-17 13:26:54 PST
Comment on attachment 452275 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452275&action=review

>> Source/WebGPU/CommandLinePlayground/main.swift:29
>> +autoreleasepool {
> 
> why does this have to be in an autoreleasepool?

It doesn't. I'll delete it.

>> Source/WebGPU/CommandLinePlayground/main.swift:36
>> +    var _ = WGPUTextureDescriptorViewFormats(chain: WGPUChainedStruct(next: nil, sType: WGPUSType(rawValue: WGPUSTypeExtended_TextureDescriptorViewFormats.rawValue)), viewFormatsCount: 0, viewFormats: nil)
> 
> let?

Yep! Good catch.

> Source/WebGPU/Configurations/CommandLinePlayground.xcconfig:24
> +PRODUCT_NAME = CommandLinePlayground;

SWIFT_VERSION = 5.0;
Comment 5 Myles C. Maxfield 2022-02-17 13:32:25 PST
Committed r290069 (?): <https://commits.webkit.org/r290069>
Comment 6 Radar WebKit Bug Importer 2022-02-17 13:33:19 PST
<rdar://problem/89105914>