Bug 236741 - Web Inspector: [Flexbox] Gaps and free space do not have pattern fills when navigating to a page with Web Inspector already open
Summary: Web Inspector: [Flexbox] Gaps and free space do not have pattern fills when n...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Patrick Angle
URL:
Keywords: InRadar
Depends on:
Blocks: 235820
  Show dependency tree / graph
 
Reported: 2022-02-16 16:10 PST by Patrick Angle
Modified: 2022-02-17 12:06 PST (History)
5 users (show)

See Also:

Attachments
Patch v1.0 (3.69 KB, patch)
2022-02-16 16:19 PST, Patrick Angle 		no flags Details | Formatted Diff | Diff
Patch v1.1 (3.97 KB, patch)
2022-02-17 08:56 PST, Patrick Angle 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Angle 2022-02-16 16:10:09 PST 
<rdar://88995157>
Comment 1 Patrick Angle 2022-02-16 16:19:38 PST 
Created attachment 452269 [details]
Patch v1.0
Comment 2 Devin Rousso 2022-02-16 18:06:29 PST 
Comment on attachment 452269 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=452269&action=review

r=me, neato :)

> Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:-365
> -    m_flexibleBoxRendererCachedItemsAtStartOfLine.clear();

I agree that it's *probably* fine to not clear since it's a `WeakHashSet`, but I am afraid this could easily be proven an incorrect analysis.  Would it make sense to clear this inside `relayoutDocument` since we're gonna do a full layout anyways (and therefore probably immediately re-fill `m_flexibleBoxRendererCachedItemsAtStartOfLine`)?
Comment 3 Patrick Angle 2022-02-17 08:56:05 PST 
Created attachment 452376 [details]
Patch v1.1
Comment 4 Patrick Angle 2022-02-17 08:58:45 PST 
Comment on attachment 452269 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=452269&action=review

>> Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:-365
>> -    m_flexibleBoxRendererCachedItemsAtStartOfLine.clear();
> 
> I agree that it's *probably* fine to not clear since it's a `WeakHashSet`, but I am afraid this could easily be proven an incorrect analysis.  Would it make sense to clear this inside `relayoutDocument` since we're gonna do a full layout anyways (and therefore probably immediately re-fill `m_flexibleBoxRendererCachedItemsAtStartOfLine`)?

Good point - I've added it to `relayoutDocument()` since we will be getting the new info anyways.
Comment 5 EWS 2022-02-17 12:06:47 PST 
Committed r290047 (247419@main): <https://commits.webkit.org/247419@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452376 [details].