Bug 236733 – Metal ANGLE: vertex array does not correctly observe contents of data buffers

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Kyle Piddington]

Metal ANGLE: vertex array does not correctly observe contents of data buffers

[Kyle Piddington]

Created attachment 452250 [details]
Patch

[Kyle Piddington]

<rdar://problem/88713302>

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

[Dean Jackson]

Comment on attachment 452250 [details]
Patch

Is there some way we could have a test for this?

[Kyle Piddington]

Created attachment 452258 [details]
Patch

[Kyle Piddington]

Created attachment 452267 [details]
Patch

[Kyle Piddington]

Comment on attachment 452258 [details]
Patch

Obsoleted, added test.

[Kyle Piddington]

D(In reply to Dean Jackson from comment #4)
> Comment on attachment 452250 [details]
> Patch
> 
> Is there some way we could have a test for this?

Done!

[Dean Jackson]

Comment on attachment 452267 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452267&action=review

I think the tests themselves are missing?

> LayoutTests/fast/canvas/buffer-data-subdata-dynamic-expected.txt:11
> +CONSOLE MESSAGE: ReferenceError: Can't find variable: debug
> +layer at (0,0) size 800x600
> +  RenderView at (0,0) size 800x600
> +layer at (0,0) size 800x60
> +  RenderBlock {HTML} at (0,0) size 800x60
> +    RenderBody {BODY} at (8,8) size 784x44
> +      RenderBlock (anonymous) at (0,0) size 784x44
> +        RenderHTMLCanvas {CANVAS} at (0,0) size 40x40
> +        RenderText {#text} at (0,0) size 0x0
> +      RenderBlock {DIV} at (0,44) size 784x0
> +      RenderBlock {DIV} at (0,44) size 784x0

Oops. Looks like the test here has a typo and isn't dumping as text.

[Kyle Piddington]

Created attachment 452421 [details]
Patch

[Kyle Piddington]

Created attachment 452431 [details]
Patch

[Dean Jackson]

Committed r290087 (247442@trunk): <https://commits.webkit.org/247442@trunk>