RESOLVED FIXED 236720
Add LC_SOURCE_VERSION to compile targets 
https://bugs.webkit.org/show_bug.cgi?id=236720
Summary Add LC_SOURCE_VERSION to compile targets
Saam Barati
Reported 2022-02-16 10:46:50 PST
...
Attachments
WIP (11.08 KB, patch)
2022-02-16 10:51 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (40.84 KB, patch)
2022-02-17 14:55 PST, Saam Barati 		msaboff: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
patch for landing (40.81 KB, patch)
2022-02-17 23:13 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2022-02-16 10:51:15 PST
Created attachment 452212 [details] WIP Needs some reworking, as I misunderstood what "$(inherited)" does. "$(inherited)" doesn't inherit from something if it's defined in a file that's included by the filed you're in. It only inherits from the thing that precedes in the xcconfig hierarchy defined by the Xcode GUI.
Saam Barati
Comment 2 2022-02-16 10:51:39 PST
<rdar://84984140>
Saam Barati
Comment 3 2022-02-17 14:55:03 PST
Created attachment 452435 [details] patch
EWS Watchlist
Comment 4 2022-02-17 14:56:41 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Michael Saboff
Comment 5 2022-02-17 15:30:07 PST
Comment on attachment 452435 [details] patch r+ Check on the EWS build failures to make sure they are related to the patch.
Alexey Proskuryakov
Comment 6 2022-02-17 15:31:50 PST
Comment on attachment 452435 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=452435&action=review > Source/JavaScriptCore/Configurations/TestAPI.xcconfig:50 > +OTHER_LDFLAGS = $(inherited) $(SOURCE_VERSION_LDFLAGS); The only thing that could be of concern AFAICT is whether any of these are overridden by OTHER_LDFLAGS variables lacking $(inherited) in other xcconfigs. I didn't immediately spot any.
Saam Barati
Comment 7 2022-02-17 17:15:36 PST
Comment on attachment 452435 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=452435&action=review >> Source/JavaScriptCore/Configurations/TestAPI.xcconfig:50 >> +OTHER_LDFLAGS = $(inherited) $(SOURCE_VERSION_LDFLAGS); > > The only thing that could be of concern AFAICT is whether any of these are overridden by OTHER_LDFLAGS variables lacking $(inherited) in other xcconfigs. I didn't immediately spot any. Right. I tried to apply my change in leaf xcconfig files, unless there was an "OTHER_LDFLAGS" already defined in a non leaf. In which case, I used that prior definition.
EWS
Comment 8 2022-02-17 22:40:56 PST
ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.
Saam Barati
Comment 9 2022-02-17 23:13:28 PST
Created attachment 452488 [details] patch for landing
EWS
Comment 10 2022-02-18 00:18:11 PST
Committed r290117 (247461@main): <https://commits.webkit.org/247461@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452488 [details].
Note You need to log in before you can comment on or make changes to this bug.