...
Created attachment 452212 [details] WIP Needs some reworking, as I misunderstood what "$(inherited)" does. "$(inherited)" doesn't inherit from something if it's defined in a file that's included by the filed you're in. It only inherits from the thing that precedes in the xcconfig hierarchy defined by the Xcode GUI.
<rdar://84984140>
Created attachment 452435 [details] patch
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment on attachment 452435 [details] patch r+ Check on the EWS build failures to make sure they are related to the patch.
Comment on attachment 452435 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=452435&action=review > Source/JavaScriptCore/Configurations/TestAPI.xcconfig:50 > +OTHER_LDFLAGS = $(inherited) $(SOURCE_VERSION_LDFLAGS); The only thing that could be of concern AFAICT is whether any of these are overridden by OTHER_LDFLAGS variables lacking $(inherited) in other xcconfigs. I didn't immediately spot any.
Comment on attachment 452435 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=452435&action=review >> Source/JavaScriptCore/Configurations/TestAPI.xcconfig:50 >> +OTHER_LDFLAGS = $(inherited) $(SOURCE_VERSION_LDFLAGS); > > The only thing that could be of concern AFAICT is whether any of these are overridden by OTHER_LDFLAGS variables lacking $(inherited) in other xcconfigs. I didn't immediately spot any. Right. I tried to apply my change in leaf xcconfig files, unless there was an "OTHER_LDFLAGS" already defined in a non leaf. In which case, I used that prior definition.
ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.
Created attachment 452488 [details] patch for landing
Committed r290117 (247461@main): <https://commits.webkit.org/247461@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452488 [details].