Bug 236718 - REGRESSION: TestWebKitAPI.WKWebViewDisableSelection.DoubleClickDoesNotSelectWhenTextInteractionsAreDisabled is failing
Summary: REGRESSION: TestWebKitAPI.WKWebViewDisableSelection.DoubleClickDoesNotSelectW...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
: 236737 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-02-16 10:40 PST by Truitt Savell
Modified: 2022-02-16 18:21 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.54 KB, patch)
2022-02-16 15:12 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch for landing (1.53 KB, patch)
2022-02-16 15:20 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2022-02-16 10:40:09 PST 
TestWebKitAPI.WKWebViewDisableSelection.DoubleClickDoesNotSelectWhenTextInteractionsAreDisabled

According to history, it looks like the changes in https://trac.webkit.org/changeset/289818/webkit broke this test. 

History:
https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.WKWebViewDisableSelection.DoubleClickDoesNotSelectWhenTextInteractionsAreDisabled

Diff;
TestWebKitAPI.WKWebViewDisableSelection.DoubleClickDoesNotSelectWhenTextInteractionsAreDisabled
        
        /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDisableSelection.mm:59
        Expected equality of these values:
          ""
          selectedText2
            Which is: "Hello"
Comment 1 Radar WebKit Bug Importer 2022-02-16 10:40:54 PST 
<rdar://problem/89034665>
Comment 2 Megan Gardner 2022-02-16 15:12:36 PST 
Created attachment 452253 [details]
Patch
Comment 3 Wenson Hsieh 2022-02-16 15:15:16 PST 
*** Bug 236737 has been marked as a duplicate of this bug. ***
Comment 4 Wenson Hsieh 2022-02-16 15:18:51 PST 
Comment on attachment 452253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452253&action=review

r=mews

> Source/WebCore/ChangeLog:6
> +        A check got missed when refactoring code for 289818.

Nit - description goes after Reviewed by line.
Comment 5 Megan Gardner 2022-02-16 15:20:06 PST 
Created attachment 452255 [details]
Patch for landing
Comment 6 EWS 2022-02-16 18:21:05 PST 
Committed r289989 (247375@main): <https://commits.webkit.org/247375@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452255 [details].