236711 – [content-visibility] Add support for css content-visibility: auto

RESOLVED FIXED 236711

[content-visibility] Add support for css content-visibility: auto

https://bugs.webkit.org/show_bug.cgi?id=236711

Summary [content-visibility] Add support for css content-visibility: auto

cathiechen

Reported 2022-02-16 09:25:29 PST

https://www.w3.org/TR/css-contain-2/#using-cv-auto

Attachments
Initial patch (18.90 KB, patch) 2022-03-09 08:18 PST, Rob Buis	no flags	Details Formatted Diff Diff
Better ChangeLog. (20.45 KB, patch) 2022-03-11 07:48 PST, Rob Buis	no flags	Details Formatted Diff Diff
Compute intersections synchronously (19.25 KB, patch) 2022-03-16 05:04 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Fix intersection computation (19.25 KB, patch) 2022-03-16 09:11 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Properly fix intersections (19.30 KB, patch) 2022-03-16 11:23 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Rebase (17.79 KB, patch) 2022-03-24 09:24 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Handle selection (20.04 KB, patch) 2022-04-06 07:11 PDT, Rob Buis	no flags	Details Formatted Diff Diff
c_v-auto-based-on-contain-intrinsic-size (23.32 KB, patch) 2022-05-17 01:12 PDT, cathiechen	no flags	Details Formatted Diff Diff
Remove ChangeLog (22.47 KB, patch) 2022-05-19 01:46 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Rebase (23.58 KB, patch) 2022-06-08 03:07 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Rebase (28.48 KB, patch) 2023-01-05 09:25 PST, Rob Buis	no flags	Details Formatted Diff Diff
Patch (32.66 KB, patch) 2023-01-10 11:42 PST, Rob Buis	no flags	Details Formatted Diff Diff
Patch (33.14 KB, patch) 2023-01-12 07:49 PST, Rob Buis	no flags	Details Formatted Diff Diff
Patch (32.90 KB, patch) 2023-01-13 01:53 PST, Rob Buis	no flags	Details Formatted Diff Diff
Patch (30.50 KB, patch) 2023-01-13 05:55 PST, Rob Buis	no flags	Details Formatted Diff Diff
Patch (31.37 KB, patch) 2023-01-17 06:56 PST, Rob Buis	no flags	Details Formatted Diff Diff
Patch (32.70 KB, patch) 2023-01-18 02:31 PST, Rob Buis	no flags	Details Formatted Diff Diff
Patch (29.12 KB, patch) 2023-01-18 03:34 PST, Rob Buis	no flags	Details Formatted Diff Diff
Patch (30.24 KB, patch) 2023-01-18 07:16 PST, Rob Buis	no flags	Details Formatted Diff Diff
Patch (31.94 KB, patch) 2023-01-19 08:13 PST, Rob Buis	no flags	Details Formatted Diff Diff
Patch (32.92 KB, patch) 2023-01-19 12:02 PST, Rob Buis	no flags	Details Formatted Diff Diff
Patch (34.30 KB, patch) 2023-01-20 06:32 PST, Rob Buis	ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (21) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2022-02-23 09:26:15 PST

<rdar://problem/89360404>

Rob Buis

Comment 2 2022-03-09 08:18:10 PST

Created attachment 454239 [details] Initial patch Initial patch.

Rob Buis

Comment 3 2022-03-11 07:48:48 PST

Created attachment 454485 [details] Better ChangeLog. Better ChangeLog.

Rob Buis

Comment 4 2022-03-16 05:04:00 PDT

Created attachment 454822 [details] Compute intersections synchronously Compute intersections synchronously.

Rob Buis

Comment 5 2022-03-16 09:11:01 PDT

Created attachment 454844 [details] Fix intersection computation Fix intersection computation, previous patch did the sync call before registration.

Rob Buis

Comment 6 2022-03-16 11:23:12 PDT

Created attachment 454866 [details] Properly fix intersections Properly fix intersections

Rob Buis

Comment 7 2022-03-24 09:24:52 PDT

Created attachment 455647 [details] Rebase Rebase.

Rob Buis

Comment 8 2022-04-06 07:11:19 PDT

Created attachment 456817 [details] Handle selection Handle selection.

cathiechen

Comment 9 2022-05-10 03:39:49 PDT

Comment on attachment 456817 [details] Handle selection View in context: https://bugs.webkit.org/attachment.cgi?id=456817&action=review > Source/WebCore/rendering/style/RenderStyle.h:543 > + bool containsSize() const { return effectiveContainment().contains(Containment::Size) || skipsContents(); } Maybe we can also move `skipsContents()` inside `effectiveContainment()`? Not sure why `containsLayout`, `containsStyle`, and `containsPaint` do not check `skipsContents()` like `containsSize`?

cathiechen

Comment 10 2022-05-10 03:39:51 PDT

Rob Buis

Comment 11 2022-05-11 02:10:03 PDT

Comment on attachment 456817 [details] Handle selection View in context: https://bugs.webkit.org/attachment.cgi?id=456817&action=review >>> Source/WebCore/rendering/style/RenderStyle.h:543 >>> + bool containsSize() const { return effectiveContainment().contains(Containment::Size) || skipsContents(); } >> >> Maybe we can also move `skipsContents()` inside `effectiveContainment()`? Not sure why `containsLayout`, `containsStyle`, and `containsPaint` do not check `skipsContents()` like `containsSize`? > > Maybe we can also move `skipsContents()` inside `effectiveContainment()`? Not sure why `containsLayout`, `containsStyle`, and `containsPaint` do not check `skipsContents()` like `containsSize`? See https://drafts.csswg.org/css-contain/#valdef-content-visibility-auto: "Turns on layout containment, style containment, and paint containment for the element." For c-v: hidden all containment is enabled. But actually, I am not sure in our patches c-v: hidden always enables size containment unconditionally....

cathiechen

Comment 12 2022-05-17 01:12:16 PDT

Created attachment 459488 [details] c_v-auto-based-on-contain-intrinsic-size The test results in this patch is based on the contain-intrinsic-size implementation patch.

Rob Buis

Comment 13 2022-05-19 01:46:32 PDT

Created attachment 459571 [details] Remove ChangeLog

Rob Buis

Comment 14 2022-06-08 03:07:55 PDT

Created attachment 460087 [details] Rebase

Rob Buis

Comment 15 2023-01-05 09:25:13 PST

Created attachment 464351 [details] Rebase

Rob Buis

Comment 16 2023-01-10 11:42:52 PST

Created attachment 464444 [details] Patch

Rob Buis

Comment 17 2023-01-12 07:49:27 PST

Created attachment 464468 [details] Patch

EWS Watchlist

Comment 18 2023-01-12 07:53:10 PST

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

Rob Buis

Comment 19 2023-01-13 01:53:43 PST

Created attachment 464480 [details] Patch

Rob Buis

Comment 20 2023-01-13 05:55:49 PST

Created attachment 464485 [details] Patch

Rob Buis

Comment 21 2023-01-17 06:56:47 PST

Created attachment 464526 [details] Patch

Rob Buis

Comment 22 2023-01-18 02:31:20 PST

Created attachment 464533 [details] Patch

Rob Buis

Comment 23 2023-01-18 03:34:23 PST

Created attachment 464534 [details] Patch

Rob Buis

Comment 24 2023-01-18 07:16:07 PST

Created attachment 464536 [details] Patch

Rob Buis

Comment 25 2023-01-19 08:13:51 PST

Created attachment 464561 [details] Patch

Rob Buis

Comment 26 2023-01-19 12:02:05 PST

Created attachment 464565 [details] Patch

Rob Buis

Comment 27 2023-01-20 06:32:18 PST

Created attachment 464578 [details] Patch

Rob Buis

Comment 28 2023-01-25 02:23:27 PST

Pull request: https://github.com/WebKit/WebKit/pull/9096

EWS

Comment 29 2023-07-15 08:29:20 PDT

Committed 266084@main (b39fee5ba22e): <https://commits.webkit.org/266084@main> Reviewed commits have been landed. Closing PR #9096 and removing active labels.

Rob Buis

Comment 30 2023-07-17 01:47:46 PDT

Re-opening for pull request https://github.com/WebKit/WebKit/pull/15879

EWS

Comment 31 2023-08-22 05:00:26 PDT

Committed 267130@main (6f118d4b6dd0): <https://commits.webkit.org/267130@main> Reviewed commits have been landed. Closing PR #15879 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Local Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component CSS

Assignee

Rob Buis

Reported

2022-02-16 09:25 PST

Modified

2023-08-22 05:00 PDT History

CC List

17 users Show

URL

Keywords InRadar

Depends on

Blocks

236238

Dependencies

tree graph