Bug 236701 - MediaPlayer::videoFrameForCurrentTime() should return VideoFrame
Summary: MediaPlayer::videoFrameForCurrentTime() should return VideoFrame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks: 236502
  Show dependency treegraph
 
Reported: 2022-02-16 02:47 PST by Kimmo Kinnunen
Modified: 2022-02-17 09:58 PST (History)
14 users (show)

See Also:


Attachments
Patch (65.82 KB, patch)
2022-02-16 02:55 PST, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff
Patch (66.65 KB, patch)
2022-02-16 04:24 PST, Kimmo Kinnunen
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (66.76 KB, patch)
2022-02-16 04:39 PST, Kimmo Kinnunen
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (66.90 KB, patch)
2022-02-16 04:47 PST, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff
Patch (66.84 KB, patch)
2022-02-16 06:38 PST, Kimmo Kinnunen
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (67.59 KB, patch)
2022-02-16 07:31 PST, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff
Patch for landing (69.98 KB, patch)
2022-02-17 03:26 PST, Kimmo Kinnunen
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (70.54 KB, patch)
2022-02-17 03:55 PST, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2022-02-16 02:47:06 PST
MediaPlayer::videoFrameForCurrentTime() should return VideoFrame
Comment 1 Kimmo Kinnunen 2022-02-16 02:55:31 PST
Created attachment 452167 [details]
Patch
Comment 2 Kimmo Kinnunen 2022-02-16 04:24:32 PST
Created attachment 452180 [details]
Patch
Comment 3 Kimmo Kinnunen 2022-02-16 04:39:26 PST
Created attachment 452183 [details]
Patch
Comment 4 Kimmo Kinnunen 2022-02-16 04:47:27 PST
Created attachment 452184 [details]
Patch
Comment 5 Kimmo Kinnunen 2022-02-16 06:38:48 PST
Created attachment 452193 [details]
Patch
Comment 6 Kimmo Kinnunen 2022-02-16 07:31:00 PST
Created attachment 452196 [details]
Patch
Comment 7 Eric Carlson 2022-02-16 13:52:59 PST
Comment on attachment 452196 [details]
Patch

The webrtc/video-rotation.html crash looks relevant.

rs=me once the bots are happy
Comment 8 Kimmo Kinnunen 2022-02-17 03:26:33 PST
Created attachment 452344 [details]
Patch for landing
Comment 9 Kimmo Kinnunen 2022-02-17 03:55:47 PST
Created attachment 452349 [details]
Patch for landing
Comment 10 EWS 2022-02-17 09:57:33 PST
Committed r290031 (247411@main): <https://commits.webkit.org/247411@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452349 [details].
Comment 11 Radar WebKit Bug Importer 2022-02-17 09:58:18 PST
<rdar://problem/89093387>