[LFC][Integration] LineLayout::firstLineBaseline callers expect physical position

[zalan]

ssia

[zalan]

Created attachment 452141 [details]
Patch

[Antti Koivisto]

Comment on attachment 452141 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452141&action=review

> Source/WebCore/rendering/RenderBlockFlow.cpp:2962
> +        return LayoutUnit { floorToInt(modernLineLayout()->firstLinePhysicalBaseline()) };

would be nice to rename RenderBlockFlow::firstLineBaseline etc too

[zalan]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 452141 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=452141&action=review
> 
> > Source/WebCore/rendering/RenderBlockFlow.cpp:2962
> > +        return LayoutUnit { floorToInt(modernLineLayout()->firstLinePhysicalBaseline()) };
> 
> would be nice to rename RenderBlockFlow::firstLineBaseline etc too
Good idea. will do it in a follow up patch!

[EWS]

Committed r289897 (247333@main): <https://commits.webkit.org/247333@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452141 [details].

[Radar WebKit Bug Importer]

<rdar://problem/89030489>