RESOLVED FIXED 236688
[LFC][Integration] LineLayout::firstLineBaseline callers expect physical position 
https://bugs.webkit.org/show_bug.cgi?id=236688
Summary [LFC][Integration] LineLayout::firstLineBaseline callers expect physical posi...
zalan
Reported 2022-02-15 21:08:10 PST
ssia
Attachments
Patch (5.99 KB, patch)
2022-02-15 21:13 PST, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2022-02-15 21:13:06 PST
Created attachment 452141 [details] Patch
Antti Koivisto
Comment 2 2022-02-16 06:37:48 PST
Comment on attachment 452141 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452141&action=review > Source/WebCore/rendering/RenderBlockFlow.cpp:2962 > + return LayoutUnit { floorToInt(modernLineLayout()->firstLinePhysicalBaseline()) }; would be nice to rename RenderBlockFlow::firstLineBaseline etc too
zalan
Comment 3 2022-02-16 06:39:47 PST
(In reply to Antti Koivisto from comment #2) > Comment on attachment 452141 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452141&action=review > > > Source/WebCore/rendering/RenderBlockFlow.cpp:2962 > > + return LayoutUnit { floorToInt(modernLineLayout()->firstLinePhysicalBaseline()) }; > > would be nice to rename RenderBlockFlow::firstLineBaseline etc too Good idea. will do it in a follow up patch!
EWS
Comment 4 2022-02-16 09:30:58 PST
Committed r289897 (247333@main): <https://commits.webkit.org/247333@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452141 [details].
Radar WebKit Bug Importer
Comment 5 2022-02-16 09:32:17 PST
<rdar://problem/89030489>
Note You need to log in before you can comment on or make changes to this bug.