Bug 236686 - Defer TerminationsExceptions while in operationMaterializeObjectInOSR.
Summary: Defer TerminationsExceptions while in operationMaterializeObjectInOSR.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-15 20:14 PST by Mark Lam
Modified: 2022-02-15 22:13 PST (History)
6 users (show)

See Also:

Attachments
proposed patch. (4.62 KB, patch)
2022-02-15 20:21 PST, Mark Lam 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2022-02-15 20:14:27 PST 
operationMaterializeObjectInOSR expects to always succeed.  It is difficult (and not worth the effort) to make it be able to handle interruptions by the TerminationException.  Since operationMaterializeObjectInOSR is guaranteed to finish running in some finite time, it is reasonable to just defer handling a pending TerminationException until the function returns.

rdar://81337114
Comment 1 Mark Lam 2022-02-15 20:21:25 PST 
Created attachment 452128 [details]
proposed patch.
Comment 2 Mark Lam 2022-02-15 22:13:01 PST 
Thanks for the review.  Landed in r289877: <http://trac.webkit.org/r289877>.