Bug 236660 - Add a new rule to decide if a font is used only for icons
Summary: Add a new rule to decide if a font is used only for icons
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-15 12:37 PST by Sihui Liu
Modified: 2022-02-15 17:48 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.62 KB, patch)
2022-02-15 13:37 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (3.72 KB, patch)
2022-02-15 14:51 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2022-02-15 12:37:09 PST 
...
Comment 1 Sihui Liu 2022-02-15 12:37:24 PST 
rdar://84829499
Comment 2 Sihui Liu 2022-02-15 13:37:10 PST 
Created attachment 452085 [details]
Patch
Comment 3 Wenson Hsieh 2022-02-15 14:25:01 PST 
Comment on attachment 452085 [details]
Patch

Seems reasonable! One quick question, though — is there a reason we require valid (non-empty) glyphs for all characters in the Arabic glyph range, rather than one or more? (Perhaps we can include an explanation for that in the ChangeLog)
Comment 4 Sihui Liu 2022-02-15 14:51:48 PST 
Created attachment 452093 [details]
Patch for landing
Comment 5 EWS 2022-02-15 17:48:54 PST 
Committed r289870 (247310@main): <https://commits.webkit.org/247310@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452093 [details].