Bug 236656 – REGRESSION(r287249): [ Monterey wk2 ] media/media-source/media-webm-vorbis-partial.html is a constant text failure

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Dawn Morningstar]

media/media-source/media-webm-vorbis-partial.html

Is a constant text failure on Monterey wk2.

HISTORY:
https://results.webkit.org/?suite=layout-tests&test=media%2Fmedia-source%2Fmedia-webm-vorbis-partial.html

DIFF:
--- /Volumes/Data/worker/monterey-release-applesilicon-tests-wk2/build/layout-test-results/media/media-source/media-webm-vorbis-partial-expected.txt
+++ /Volumes/Data/worker/monterey-release-applesilicon-tests-wk2/build/layout-test-results/media/media-source/media-webm-vorbis-partial-actual.txt
@@ -1,13 +1,22 @@
 
 RUN(video.src = URL.createObjectURL(source))
 EVENT(sourceopen)
-RUN(source.duration = loader.duration())
 RUN(sourceBuffer = source.addSourceBuffer(loader.type()))
 RUN(sourceBuffer.appendBuffer(loader.initSegment()))
 EVENT(update)
-Append a media segment.
-RUN(sourceBuffer.appendBuffer(loader.mediaSegment(0)))
+Divide the first media segment in two.
+RUN(partial1 = loader.mediaSegment(0).slice(0, loader.mediaSegment(0).byteLength / 2))
+RUN(partial2 = loader.mediaSegment(0).slice(loader.mediaSegment(0).byteLength / 2))
+Append a partial media segment.
+RUN(sourceBuffer.appendBuffer(partial1))
 EVENT(update)
+EXPECTED (sourceBuffer.buffered.length == '1') OK
+EXPECTED (sourceBuffer.buffered.end(0).toFixed(2) == '0.64') OK
+Complete the partial media segment.
+RUN(sourceBuffer.appendBuffer(partial2))
+EVENT(update)
+EXPECTED (sourceBuffer.buffered.length == '1') OK
+EXPECTED (sourceBuffer.buffered.end(0).toFixed(2) == '1.34') OK
 EXPECTED (sourceBuffer.buffered.end(0) == source.duration == 'true') OK
 END OF TEST
 
DIFF-URL:
https://build.webkit.org/results/Apple-Monterey-Release-AppleSilicon-WK2-Tests/r289816%20(1758)/media/media-source/media-webm-vorbis-partial-diff.txt

[Radar WebKit Bug Importer]

<rdar://problem/88978504>

[Dawn Morningstar]

Failure was reproduced at Monterey Production TOT using:
run-webkit-tests media/media-source/media-webm-vorbis-partial.html

History appears to show regression point at r287249:
https://trac.webkit.org/changeset/287249/webkit

Fix appears to have been attempted at r289196 however test still appears broken:
https://trac.webkit.org/changeset/289196/webkit

When testing regression point, failure was continuing even before revision, however this is likely due to the change in the test itself.

[Dawn Morningstar]

Created attachment 452090 [details]
update test expectations

[Robert Jenner]

Comment on attachment 452090 [details]
update test expectations

Clearing flags on attachment: 452090

Committed r289853 (247295@trunk): <https://commits.webkit.org/247295@trunk>

[Jean-Yves Avenard [:jya]]

Comment on attachment 452090 [details]
update test expectations

The expected file didn't get committed with my previous fix, need to reset that.

[Ryan Haddad]

(In reply to Jean-Yves Avenard [:jya] from comment #5)
> Comment on attachment 452090 [details]
> update test expectations
> 
> The expected file didn't get committed with my previous fix, need to reset
> that.
Has this been addressed? It looks like the test is still consistently failing.

[Dawn Morningstar]

(In reply to Ryan Haddad from comment #6)
> (In reply to Jean-Yves Avenard [:jya] from comment #5)
> > Comment on attachment 452090 [details]
> > update test expectations
> > 
> > The expected file didn't get committed with my previous fix, need to reset
> > that.
> Has this been addressed? It looks like the test is still consistently
> failing.

Confirmed still constantly failing.

[Jean-Yves Avenard [:jya]]

Created attachment 454660 [details]
Patch

[EWS]

Committed r291319 (248458@main): <https://commits.webkit.org/248458@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454660 [details].