Bug 236652 - Add a dedicated ENABLE flag for MediaRecorder
Summary: Add a dedicated ENABLE flag for MediaRecorder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-15 10:14 PST by Philippe Normand
Modified: 2022-02-16 09:21 PST (History)
17 users (show)

See Also:


Attachments
Patch (20.52 KB, patch)
2022-02-15 10:17 PST, Philippe Normand
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (22.30 KB, patch)
2022-02-15 10:31 PST, Philippe Normand
no flags Details | Formatted Diff | Diff
Patch (28.43 KB, patch)
2022-02-16 01:41 PST, Philippe Normand
no flags Details | Formatted Diff | Diff
Patch (29.95 KB, patch)
2022-02-16 03:31 PST, Philippe Normand
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2022-02-15 10:14:52 PST
It should depend on MEDIA_STREAM and be enabled only for PLATFORM(COCOA) for now.
Comment 1 Philippe Normand 2022-02-15 10:17:27 PST
Created attachment 452045 [details]
Patch
Comment 2 Philippe Normand 2022-02-15 10:22:11 PST
EWS is not happy :)
Comment 3 Philippe Normand 2022-02-15 10:31:42 PST
Created attachment 452047 [details]
Patch
Comment 4 Philippe Normand 2022-02-15 10:37:35 PST
Comment on attachment 452047 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452047&action=review

> Source/WebCore/Modules/mediarecorder/MediaRecorderProvider.cpp:42
> +#if PLATFORM(COCOA)

Should I add USE(AVFOUNDATION) here?
Comment 5 Eric Carlson 2022-02-15 16:46:59 PST
Comment on attachment 452047 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452047&action=review

r=me once the bots are happy

>> Source/WebCore/Modules/mediarecorder/MediaRecorderProvider.cpp:42
>> +#if PLATFORM(COCOA)
> 
> Should I add USE(AVFOUNDATION) here?

Good idea
Comment 6 Philippe Normand 2022-02-16 01:41:54 PST
Created attachment 452160 [details]
Patch
Comment 7 Philippe Normand 2022-02-16 03:31:31 PST
Created attachment 452173 [details]
Patch
Comment 8 EWS 2022-02-16 09:20:31 PST
Committed r289894 (247331@main): <https://commits.webkit.org/247331@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452173 [details].
Comment 9 Radar WebKit Bug Importer 2022-02-16 09:21:20 PST
<rdar://problem/89029790>