Bug 236651 - Share WebKitTestRunner code among USE(LIBWPE) ports
Summary: Share WebKitTestRunner code among USE(LIBWPE) ports
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-15 10:11 PST by Don Olmstead
Modified: 2022-02-16 05:55 PST (History)
8 users (show)

See Also:

Attachments
Patch (8.81 KB, patch)
2022-02-15 10:47 PST, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (10.72 KB, patch)
2022-02-15 10:50 PST, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (10.72 KB, patch)
2022-02-15 11:13 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (10.72 KB, patch)
2022-02-15 11:18 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2022-02-15 10:11:06 PST 
The PlatformWebView and EventSenderProxy implementations just use libwpe directly.
Comment 1 Don Olmstead 2022-02-15 10:47:30 PST Comment hidden (obsolete)
Comment 2 Don Olmstead 2022-02-15 10:50:52 PST Comment hidden (obsolete)
Comment 3 Don Olmstead 2022-02-15 11:13:39 PST Comment hidden (obsolete)
Comment 4 Don Olmstead 2022-02-15 11:18:07 PST 
Created attachment 452061 [details]
Patch
Comment 5 Don Olmstead 2022-02-15 13:49:12 PST 
AppleWin doesn't use WebKitTestRunner so the failure is unrelated to this change.
Comment 6 Zan Dobersek (Reviews) 2022-02-15 22:47:04 PST 
Comment on attachment 452061 [details]
Patch

LGTM.
Comment 7 EWS 2022-02-16 05:54:22 PST 
Committed r289887 (247325@main): <https://commits.webkit.org/247325@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452061 [details].
Comment 8 Radar WebKit Bug Importer 2022-02-16 05:55:17 PST 
<rdar://problem/89021314>