RESOLVED FIXED 23663
Should add void toRenderBox method to catch unnecessary casts 
https://bugs.webkit.org/show_bug.cgi?id=23663
Summary Should add void toRenderBox method to catch unnecessary casts
Adam Treat
Reported 2009-01-31 08:26:14 PST
RenderBox should add a void toRenderBox method to catch unnecessary casts much like David Hyatt has added for other RenderFoo classes.
Attachments
Add void toRenderBox casting method (4.18 KB, patch)
2009-01-31 08:27 PST, Adam Treat 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Treat
Comment 1 2009-01-31 08:27:59 PST
Created attachment 27217 [details] Add void toRenderBox casting method Adds the check and also fixes four cases of unnecessary toRenderBox casts.
Darin Adler
Comment 2 2009-01-31 08:55:33 PST
Comment on attachment 27217 [details] Add void toRenderBox casting method > +// This will catch anyone doing an unnecessary cast. > +void toRenderBox(const RenderBox* o); We should leave out the "o" here. r=me
Adam Treat
Comment 3 2009-01-31 10:08:27 PST
Fixed with r40452.
Note You need to log in before you can comment on or make changes to this bug.