Bug 236605 - [CMake] Remove uses of add_definitions in JavaScriptCore build
Summary: [CMake] Remove uses of add_definitions in JavaScriptCore build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-14 12:59 PST by Don Olmstead
Modified: 2022-02-14 16:10 PST (History)
11 users (show)

See Also:


Attachments
Patch (2.63 KB, patch)
2022-02-14 13:19 PST, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2022-02-14 12:59:53 PST
Use modern CMake way of setting definitions.
Comment 1 Don Olmstead 2022-02-14 13:19:16 PST
Created attachment 451936 [details]
Patch
Comment 2 EWS 2022-02-14 16:10:23 PST
Committed r289779 (247247@main): <https://commits.webkit.org/247247@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451936 [details].