Bug 236602 - [macOS] Add a context menu item to "Copy Cropped Image"
Summary: [macOS] Add a context menu item to "Copy Cropped Image"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks: 236628
  Show dependency tree / graph
 
Reported: 2022-02-14 12:01 PST by Wenson Hsieh
Modified: 2022-02-15 13:58 PST (History)
9 users (show)

See Also:

Attachments
Patch (25.83 KB, patch)
2022-02-14 12:20 PST, Wenson Hsieh 		megan_gardner: review+
Details | Formatted Diff | Diff
Patch for landing (25.90 KB, patch)
2022-02-15 11:43 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2022-02-14 12:01:25 PST 
.
Comment 1 Wenson Hsieh 2022-02-14 12:20:22 PST 
Created attachment 451931 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2022-02-14 13:13:30 PST 
<rdar://problem/88924479>
Comment 3 Megan Gardner 2022-02-15 11:15:47 PST 
Comment on attachment 451931 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451931&action=review

> Source/WebCore/page/ContextMenuController.cpp:258
> +        break;

Why are we sure we won't ever get here?
Comment 4 Wenson Hsieh 2022-02-15 11:20:21 PST 
Comment on attachment 451931 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451931&action=review

Thanks for the review!

>> Source/WebCore/page/ContextMenuController.cpp:258
>> +        break;
> 
> Why are we sure we won't ever get here?

Good question! We won't ever get here because we expect to handle this item in the client layer, similar to ContextMenuItemTagQuickLookImage.

I'll move this case down next to ContextMenuItemTagQuickLookImage, so that the "This should be handled at the client layer." comment will apply to both.
Comment 5 Wenson Hsieh 2022-02-15 11:43:48 PST 
Created attachment 452070 [details]
Patch for landing
Comment 6 EWS 2022-02-15 13:58:22 PST 
Committed r289851 (247293@main): <https://commits.webkit.org/247293@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452070 [details].