Bug 236571 - Consistenly use hasTagName instead of is<> in HTMLStackItem testing functions
Summary: Consistenly use hasTagName instead of is<> in HTMLStackItem testing functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-13 14:16 PST by Cameron McCormack (:heycam)
Modified: 2022-02-14 16:02 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.20 KB, patch)
2022-02-13 14:19 PST, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2022-02-13 14:16:06 PST 
No reason to use is<> for a couple of element names but hasTagName for all others.
Comment 1 Cameron McCormack (:heycam) 2022-02-13 14:19:04 PST 
Created attachment 451843 [details]
Patch
Comment 2 Sam Weinig 2022-02-14 13:26:42 PST 
Comment on attachment 451843 [details]
Patch

Looks like this was done intentionally way back in http://trac.webkit.org/changeset/152440/webkit, but also seems like it was not the right choice.
Comment 3 EWS 2022-02-14 16:01:17 PST 
Committed r289777 (247245@main): <https://commits.webkit.org/247245@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451843 [details].
Comment 4 Radar WebKit Bug Importer 2022-02-14 16:02:17 PST 
<rdar://problem/88933767>