RESOLVED FIXED 23657
Clean up Storage IDLs 
https://bugs.webkit.org/show_bug.cgi?id=23657
Summary Clean up Storage IDLs
Dimitri Glazkov (Google)
Reported 2009-01-30 15:00:11 PST
All callbacks are custom-baked, so there's no need for their IDLs to float around. Also, I flipped int attributes to be long in SQLError and SQLResultSet, as spec suggested. This is purely cosmetic, but makes our IDLs match the spec better.
Attachments
v1 submitted for review (9.41 KB, patch)
2009-01-30 15:03 PST, Dimitri Glazkov (Google) 		sam: review+
DetailsFormatted DiffDiff
Remove IDLs from the project (3.70 KB, patch)
2009-03-03 13:20 PST, Dimitri Glazkov (Google) 		fishd: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2009-01-30 15:03:30 PST
Created attachment 27198 [details] v1 submitted for review WebCore/ChangeLog | 14 +++++++++ WebCore/storage/SQLError.idl | 2 +- WebCore/storage/SQLResultSet.idl | 4 +- WebCore/storage/SQLStatementCallback.idl | 35 ----------------------- WebCore/storage/SQLStatementErrorCallback.idl | 35 ----------------------- WebCore/storage/SQLTransactionCallback.idl | 35 ----------------------- WebCore/storage/SQLTransactionErrorCallback.idl | 35 ----------------------- 7 files changed, 17 insertions(+), 143 deletions(-)
Dimitri Glazkov (Google)
Comment 2 2009-02-04 15:36:47 PST
Landed as http://trac.webkit.org/changeset/40633.
Dimitri Glazkov (Google)
Comment 3 2009-03-03 13:19:24 PST
How annoying. I forgot to remove these IDLs from the XCode project. Now they are taunting me with redness.
Dimitri Glazkov (Google)
Comment 4 2009-03-03 13:20:59 PST
Created attachment 28237 [details] Remove IDLs from the project WebCore/ChangeLog | 10 ++++++++++ WebCore/WebCore.xcodeproj/project.pbxproj | 8 -------- 2 files changed, 10 insertions(+), 8 deletions(-)
Dimitri Glazkov (Google)
Comment 5 2009-03-03 14:59:46 PST
Project fix-up landed in http://trac.webkit.org/changeset/41408.
Note You need to log in before you can comment on or make changes to this bug.