RESOLVED FIXED236567
Make StructureMemoryManager alignment assert a RELEASE_ASSERT 
https://bugs.webkit.org/show_bug.cgi?id=236567
Summary Make StructureMemoryManager alignment assert a RELEASE_ASSERT
Keith Miller
Reported 2022-02-13 11:41:02 PST
Make StructureMemoryManager alignment assert a RELEASE_ASSERT
Attachments
Patch (1.56 KB, patch)
2022-02-13 11:41 PST, Keith Miller 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2022-02-13 11:41:50 PST
Created attachment 451831 [details] Patch
Saam Barati
Comment 2 2022-02-13 11:43:41 PST
Comment on attachment 451831 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451831&action=review r=me > Source/JavaScriptCore/heap/StructureAlignedMemoryAllocator.cpp:85 > + RELEASE_ASSERT(g_jscConfig.startOfStructureHeap && ((g_jscConfig.startOfStructureHeap & ~structureIDMask) == g_jscConfig.startOfStructureHeap)); let's also release assert it's not null.
Saam Barati
Comment 3 2022-02-13 11:44:00 PST
Comment on attachment 451831 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451831&action=review >> Source/JavaScriptCore/heap/StructureAlignedMemoryAllocator.cpp:85 >> + RELEASE_ASSERT(g_jscConfig.startOfStructureHeap && ((g_jscConfig.startOfStructureHeap & ~structureIDMask) == g_jscConfig.startOfStructureHeap)); > > let's also release assert it's not null. lol, I should read the code before commenting :-)
Keith Miller
Comment 4 2022-02-13 11:45:31 PST
Comment on attachment 451831 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451831&action=review >>> Source/JavaScriptCore/heap/StructureAlignedMemoryAllocator.cpp:85 >>> + RELEASE_ASSERT(g_jscConfig.startOfStructureHeap && ((g_jscConfig.startOfStructureHeap & ~structureIDMask) == g_jscConfig.startOfStructureHeap)); >> >> let's also release assert it's not null. > > lol, I should read the code before commenting :-) :P
EWS
Comment 5 2022-02-13 12:23:35 PST
Committed r289717 (247202@main): <https://commits.webkit.org/247202@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451831 [details].
Radar WebKit Bug Importer
Comment 6 2022-02-13 12:24:16 PST
<rdar://problem/88875697>
Note You need to log in before you can comment on or make changes to this bug.