Make StructureMemoryManager alignment assert a RELEASE_ASSERT
Created attachment 451831 [details] Patch
Comment on attachment 451831 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451831&action=review r=me > Source/JavaScriptCore/heap/StructureAlignedMemoryAllocator.cpp:85 > + RELEASE_ASSERT(g_jscConfig.startOfStructureHeap && ((g_jscConfig.startOfStructureHeap & ~structureIDMask) == g_jscConfig.startOfStructureHeap)); let's also release assert it's not null.
Comment on attachment 451831 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451831&action=review >> Source/JavaScriptCore/heap/StructureAlignedMemoryAllocator.cpp:85 >> + RELEASE_ASSERT(g_jscConfig.startOfStructureHeap && ((g_jscConfig.startOfStructureHeap & ~structureIDMask) == g_jscConfig.startOfStructureHeap)); > > let's also release assert it's not null. lol, I should read the code before commenting :-)
Comment on attachment 451831 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451831&action=review >>> Source/JavaScriptCore/heap/StructureAlignedMemoryAllocator.cpp:85 >>> + RELEASE_ASSERT(g_jscConfig.startOfStructureHeap && ((g_jscConfig.startOfStructureHeap & ~structureIDMask) == g_jscConfig.startOfStructureHeap)); >> >> let's also release assert it's not null. > > lol, I should read the code before commenting :-) :P
Committed r289717 (247202@main): <https://commits.webkit.org/247202@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451831 [details].
<rdar://problem/88875697>