Bug 236567 - Make StructureMemoryManager alignment assert a RELEASE_ASSERT
Summary: Make StructureMemoryManager alignment assert a RELEASE_ASSERT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-13 11:41 PST by Keith Miller
Modified: 2022-02-13 13:12 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.56 KB, patch)
2022-02-13 11:41 PST, Keith Miller
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2022-02-13 11:41:02 PST
Make StructureMemoryManager alignment assert a RELEASE_ASSERT
Comment 1 Keith Miller 2022-02-13 11:41:50 PST
Created attachment 451831 [details]
Patch
Comment 2 Saam Barati 2022-02-13 11:43:41 PST
Comment on attachment 451831 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451831&action=review

r=me

> Source/JavaScriptCore/heap/StructureAlignedMemoryAllocator.cpp:85
> +        RELEASE_ASSERT(g_jscConfig.startOfStructureHeap && ((g_jscConfig.startOfStructureHeap & ~structureIDMask) == g_jscConfig.startOfStructureHeap));

let's also release assert it's not null.
Comment 3 Saam Barati 2022-02-13 11:44:00 PST
Comment on attachment 451831 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451831&action=review

>> Source/JavaScriptCore/heap/StructureAlignedMemoryAllocator.cpp:85
>> +        RELEASE_ASSERT(g_jscConfig.startOfStructureHeap && ((g_jscConfig.startOfStructureHeap & ~structureIDMask) == g_jscConfig.startOfStructureHeap));
> 
> let's also release assert it's not null.

lol, I should read the code before commenting :-)
Comment 4 Keith Miller 2022-02-13 11:45:31 PST
Comment on attachment 451831 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451831&action=review

>>> Source/JavaScriptCore/heap/StructureAlignedMemoryAllocator.cpp:85
>>> +        RELEASE_ASSERT(g_jscConfig.startOfStructureHeap && ((g_jscConfig.startOfStructureHeap & ~structureIDMask) == g_jscConfig.startOfStructureHeap));
>> 
>> let's also release assert it's not null.
> 
> lol, I should read the code before commenting :-)

:P
Comment 5 EWS 2022-02-13 12:23:35 PST
Committed r289717 (247202@main): <https://commits.webkit.org/247202@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451831 [details].
Comment 6 Radar WebKit Bug Importer 2022-02-13 12:24:16 PST
<rdar://problem/88875697>