236560 – [JSC] Fix test sharding when using --make-runner and --remote

Bug 236560 - [JSC] Fix test sharding when using --make-runner and --remote

Summary: [JSC] Fix test sharding when using --make-runner and --remote

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Angelos Oikonomopoulos

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2022-02-13 04:34 PST by Angelos Oikonomopoulos
Modified:	2022-03-08 02:19 PST (History)
CC List:	5 users (show)

See Also:

Attachments
Patch (2.56 KB, patch) 2022-02-13 04:36 PST, Angelos Oikonomopoulos	no flags	Details \| Formatted Diff \| Diff
Patch (2.83 KB, patch) 2022-02-15 07:21 PST, Angelos Oikonomopoulos	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Angelos Oikonomopoulos 2022-02-13 04:34:28 PST

[JSC] Fix test sharding when using --remote

Comment 1 Angelos Oikonomopoulos 2022-02-13 04:36:48 PST

Created attachment 451814 [details]
Patch

Comment 2 Angelos Oikonomopoulos 2022-02-15 07:21:55 PST

Created attachment 452020 [details]
Patch

Comment 3 Angelos Oikonomopoulos 2022-02-15 12:17:47 PST

For reviewers who might be unfamiliar with ruby: @remoteHosts refers to an instance variable of the class (a field) and defaults to nil if the variable doesn't exist. The patch has prepareRunnerForRemote accept remoteHosts as an argument instead and updates all callers.

Comment 4 Angelos Oikonomopoulos 2022-02-15 12:21:00 PST

Oh, also to the best of my knowledge --make-runner is not used with --remote in any public buildbot.

Comment 5 EWS 2022-02-18 20:05:56 PST

Tools/Scripts/svn-apply failed to apply attachment 452020 [details] to trunk.
Please resolve the conflicts and upload a new patch.

Comment 6 Radar WebKit Bug Importer 2022-02-20 04:35:15 PST

<rdar://problem/89202446>

Comment 7 Aakash Jain 2022-02-21 05:05:47 PST

Comment on attachment 452020 [details]
Patch

Commit-Queue landed it in https://ews-build.webkit.org/#/builders/28/builds/19893

https://commits.webkit.org/247513@main (r290185)

Comment 8 Adrian Perez 2022-03-08 02:19:29 PST

Closing as fixed, because the patch has landed :)