Bug 236542 - Use more references instead of never-null pointers in JavaScript bindings, cast to JSDOMGlobalObject at boundaries, simplify legacy plug-in and Objective-C binding code
Summary: Use more references instead of never-null pointers in JavaScript bindings, ca...
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-12 15:14 PST by Darin Adler
Modified: 2022-02-27 15:12 PST (History)
37 users (show)

See Also:

Attachments
Patch (1.39 MB, patch)
2022-02-12 15:22 PST, Darin Adler 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (4.41 MB, patch)
2022-02-13 10:46 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (4.41 MB, patch)
2022-02-14 09:27 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (4.41 MB, patch)
2022-02-16 13:23 PST, Darin Adler 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (4.41 MB, patch)
2022-02-16 15:20 PST, Darin Adler 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (4.41 MB, patch)
2022-02-16 16:29 PST, Darin Adler 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (4.41 MB, patch)
2022-02-16 21:18 PST, Darin Adler 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (4.41 MB, patch)
2022-02-17 01:13 PST, Darin Adler 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (4.41 MB, patch)
2022-02-17 08:59 PST, Darin Adler 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (4.41 MB, patch)
2022-02-17 11:02 PST, Darin Adler 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (4.41 MB, patch)
2022-02-17 15:27 PST, Darin Adler 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (4.42 MB, patch)
2022-02-17 19:45 PST, Darin Adler 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (4.42 MB, patch)
2022-02-18 13:00 PST, Darin Adler 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (4.42 MB, patch)
2022-02-21 12:34 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (4.44 MB, patch)
2022-02-24 17:49 PST, Darin Adler 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (4.45 MB, patch)
2022-02-27 13:08 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
Show Obsolete (15) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2022-02-12 15:14:57 PST 
Use more references instead of never-null pointers in JavaScript bindings, cast to JSDOMGlobalObject at boundaries, simplify legacy plug-in and Objective-C binding code
Comment 1 Darin Adler 2022-02-12 15:22:20 PST Comment hidden (obsolete)
Comment 2 Darin Adler 2022-02-13 10:46:03 PST Comment hidden (obsolete)
Comment 3 Darin Adler 2022-02-14 09:27:09 PST Comment hidden (obsolete)
Comment 4 Darin Adler 2022-02-16 13:23:12 PST Comment hidden (obsolete)
Comment 5 Darin Adler 2022-02-16 15:20:41 PST Comment hidden (obsolete)
Comment 6 Darin Adler 2022-02-16 16:29:50 PST Comment hidden (obsolete)
Comment 7 Darin Adler 2022-02-16 21:18:23 PST Comment hidden (obsolete)
Comment 8 Darin Adler 2022-02-17 01:13:12 PST Comment hidden (obsolete)
Comment 9 Darin Adler 2022-02-17 08:52:22 PST 
No way I am going to be able to land all of this at once, but I like the changes in it and will try to find a way to do them all.
Comment 10 Darin Adler 2022-02-17 08:59:39 PST Comment hidden (obsolete)
Comment 11 Darin Adler 2022-02-17 11:02:11 PST Comment hidden (obsolete)
Comment 12 Darin Adler 2022-02-17 15:27:10 PST Comment hidden (obsolete)
Comment 13 Darin Adler 2022-02-17 19:45:51 PST Comment hidden (obsolete)
Comment 14 Aakash Jain 2022-02-18 08:34:09 PST Comment hidden (obsolete)
Comment 15 Darin Adler 2022-02-18 13:00:21 PST Comment hidden (obsolete)
Comment 16 Radar WebKit Bug Importer 2022-02-19 15:15:27 PST 
<rdar://problem/89192774>
Comment 17 Darin Adler 2022-02-21 12:34:01 PST Comment hidden (obsolete)
Comment 18 Darin Adler 2022-02-21 16:48:18 PST 
Finally compiling on all platforms. Still got some crashes (most likely missing null-checks) to tix.
Comment 19 Jonathan Bedard 2022-02-22 07:26:32 PST Comment hidden (obsolete)
Comment 20 Aakash Jain 2022-02-23 13:37:07 PST Comment hidden (obsolete)
Comment 21 Darin Adler 2022-02-24 17:49:19 PST Comment hidden (obsolete)
Comment 22 Darin Adler 2022-02-27 13:08:26 PST 
Created attachment 453354 [details]
Patch
Comment 23 Darin Adler 2022-02-27 15:12:55 PST 
Looks like all tests are passing now. Time to break this up into smaller pieces to land it.