Bug 236516 - Regression(r285501) Microsoft teams meeting URLs fail to open the app
Summary: Regression(r285501) Microsoft teams meeting URLs fail to open the app
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 231727
  Show dependency tree / graph
 
Reported: 2022-02-11 10:21 PST by Chris Dumez
Modified: 2022-02-11 14:55 PST (History)
10 users (show)

See Also:

Attachments
Patch (5.77 KB, patch)
2022-02-11 10:24 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (5.73 KB, patch)
2022-02-11 10:43 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-02-11 10:21:51 PST 
Microsoft teams meeting URLs fail to open the app since r287684.
Comment 1 Chris Dumez 2022-02-11 10:22:01 PST 
<rdar://88678598>
Comment 2 Chris Dumez 2022-02-11 10:24:10 PST 
Created attachment 451721 [details]
Patch
Comment 3 Geoffrey Garen 2022-02-11 10:34:52 PST 
Comment on attachment 451721 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451721&action=review

> Source/WebCore/page/Quirks.cpp:1419
> +bool Quirks::shouldAllowNavigationToCustomProtocolWithoutUserGesture(StringView protocol, const SecurityOriginData& requesterOrigin)

Can we disable the quirk when quirks are disabled in the Develop menu?
Comment 4 Chris Dumez 2022-02-11 10:40:13 PST 
(In reply to Geoffrey Garen from comment #3)
> Comment on attachment 451721 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=451721&action=review
> 
> > Source/WebCore/page/Quirks.cpp:1419
> > +bool Quirks::shouldAllowNavigationToCustomProtocolWithoutUserGesture(StringView protocol, const SecurityOriginData& requesterOrigin)
> 
> Can we disable the quirk when quirks are disabled in the Develop menu?

It is not as easy as usually since we're in the UIProcess but I'll see if I can get the setting value from there.
Comment 5 Chris Dumez 2022-02-11 10:43:03 PST 
Created attachment 451724 [details]
Patch
Comment 6 Chris Dumez 2022-02-11 11:10:38 PST 
(In reply to Geoffrey Garen from comment #3)
> Comment on attachment 451721 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=451721&action=review
> 
> > Source/WebCore/page/Quirks.cpp:1419
> > +bool Quirks::shouldAllowNavigationToCustomProtocolWithoutUserGesture(StringView protocol, const SecurityOriginData& requesterOrigin)
> 
> Can we disable the quirk when quirks are disabled in the Develop menu?

Done before landing.
Comment 7 EWS 2022-02-11 12:20:57 PST 
Committed r289658 (247150@main): <https://commits.webkit.org/247150@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451724 [details].
Comment 8 Sihui Liu 2022-02-11 14:54:00 PST 
Is the regression point in the title correct?
Comment 9 Chris Dumez 2022-02-11 14:54:47 PST 
(In reply to Sihui Liu from comment #8)
> Is the regression point in the title correct?

Hmm, no. I'll fix it, thanks.