RESOLVED FIXED 236511
[iOS] Add a "Copy Cropped Image" context menu item when long pressing images 
https://bugs.webkit.org/show_bug.cgi?id=236511
Summary [iOS] Add a "Copy Cropped Image" context menu item when long pressing images
Wenson Hsieh
Reported 2022-02-11 08:48:15 PST
rdar://88817219
Attachments
Patch (42.72 KB, patch)
2022-02-11 11:12 PST, Wenson Hsieh 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Try to fix Big Sur build (44.15 KB, patch)
2022-02-11 12:20 PST, Wenson Hsieh 		hi: review+
DetailsFormatted DiffDiff
For landing (44.11 KB, patch)
2022-02-11 14:43 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2022-02-11 11:12:56 PST Comment hidden (obsolete)
Wenson Hsieh
Comment 2 2022-02-11 12:20:47 PST
Created attachment 451735 [details] Try to fix Big Sur build
Devin Rousso
Comment 3 2022-02-11 13:29:20 PST
Comment on attachment 451735 [details] Try to fix Big Sur build View in context: https://bugs.webkit.org/attachment.cgi?id=451735&action=review r=me, great work :) > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:559 > + // FIXME: This should be additionally gated on the relevant VisionKit SPI. bugzilla/radar? > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:595 > + // FIXME: This should be additionally gated on the relevant VisionKit SPI. ditto (:559)
Wenson Hsieh
Comment 4 2022-02-11 14:10:00 PST
Comment on attachment 451735 [details] Try to fix Big Sur build View in context: https://bugs.webkit.org/attachment.cgi?id=451735&action=review >> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:559 >> + // FIXME: This should be additionally gated on the relevant VisionKit SPI. > > bugzilla/radar? Good point — added a radar link. >> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:595 >> + // FIXME: This should be additionally gated on the relevant VisionKit SPI. > > ditto (:559) 👍🏻
Wenson Hsieh
Comment 5 2022-02-11 14:43:03 PST
Created attachment 451747 [details] For landing
EWS
Comment 6 2022-02-11 17:13:18 PST
Committed r289681 (247167@main): <https://commits.webkit.org/247167@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451747 [details].
Note You need to log in before you can comment on or make changes to this bug.