WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
236504
Git commit message hook should allow source = 'template' case
https://bugs.webkit.org/show_bug.cgi?id=236504
Summary
Git commit message hook should allow source = 'template' case
Jonathan Bedard
Reported
2022-02-11 07:06:47 PST
Certain Git tools change what source is in our hook, we should support those tools.
Attachments
Patch
(1.20 KB, patch)
2022-02-11 07:08 PST
,
Jonathan Bedard
no flags
Details
Formatted Diff
Diff
Patch
(1.22 KB, patch)
2022-02-11 10:47 PST
,
Jonathan Bedard
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Jonathan Bedard
Comment 1
2022-02-11 07:07:13 PST
<
rdar://problem/88787806
>
Jonathan Bedard
Comment 2
2022-02-11 07:08:23 PST
Created
attachment 451689
[details]
Patch
eddy_wong
Comment 3
2022-02-11 10:43:24 PST
Comment on
attachment 451689
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=451689&action=review
> Tools/Scripts/hooks/prepare-commit-msg:45 > + if source not in ('commit', 'template'):
source could be None too
Jonathan Bedard
Comment 4
2022-02-11 10:44:54 PST
(In reply to eddy_wong from
comment #3
)
> Comment on
attachment 451689
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=451689&action=review
> > > Tools/Scripts/hooks/prepare-commit-msg:45 > > + if source not in ('commit', 'template'): > > source could be None too
Oops, good point, messed that one up.... (as a side note, the case that doesn't fall into any of these categories is the rebase one)
Jonathan Bedard
Comment 5
2022-02-11 10:47:27 PST
Created
attachment 451725
[details]
Patch
EWS
Comment 6
2022-02-11 12:08:56 PST
Committed
r289656
(
247149@main
): <
https://commits.webkit.org/247149@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 451725
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug