Bug 236504 - Git commit message hook should allow source = 'template' case
Summary: Git commit message hook should allow source = 'template' case
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-11 07:06 PST by Jonathan Bedard
Modified: 2022-02-11 12:08 PST (History)
8 users (show)

See Also:

Attachments
Patch (1.20 KB, patch)
2022-02-11 07:08 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (1.22 KB, patch)
2022-02-11 10:47 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2022-02-11 07:06:47 PST 
Certain Git tools change what source is in our hook, we should support those tools.
Comment 1 Jonathan Bedard 2022-02-11 07:07:13 PST 
<rdar://problem/88787806>
Comment 2 Jonathan Bedard 2022-02-11 07:08:23 PST 
Created attachment 451689 [details]
Patch
Comment 3 eddy_wong 2022-02-11 10:43:24 PST 
Comment on attachment 451689 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451689&action=review

> Tools/Scripts/hooks/prepare-commit-msg:45
> +    if source not in ('commit', 'template'):

source could be None too
Comment 4 Jonathan Bedard 2022-02-11 10:44:54 PST 
(In reply to eddy_wong from comment #3)
> Comment on attachment 451689 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=451689&action=review
> 
> > Tools/Scripts/hooks/prepare-commit-msg:45
> > +    if source not in ('commit', 'template'):
> 
> source could be None too

Oops, good point, messed that one up....

(as a side note, the case that doesn't fall into any of these categories is the rebase one)
Comment 5 Jonathan Bedard 2022-02-11 10:47:27 PST 
Created attachment 451725 [details]
Patch
Comment 6 EWS 2022-02-11 12:08:56 PST 
Committed r289656 (247149@main): <https://commits.webkit.org/247149@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451725 [details].