Bug 236490 - ExtensionsGL is not useful class, it should be removed
Summary: ExtensionsGL is not useful class, it should be removed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks: gcgranglecleanup
  Show dependency tree / graph
 
Reported: 2022-02-11 00:06 PST by Kimmo Kinnunen
Modified: 2022-02-14 23:35 PST (History)
20 users (show)

See Also:

Attachments
Patch (269.62 KB, patch)
2022-02-11 00:51 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
For EWS (271.79 KB, patch)
2022-02-11 04:15 PST, Kimmo Kinnunen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
For EWS (271.82 KB, patch)
2022-02-11 05:01 PST, Kimmo Kinnunen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
For EWS (272.84 KB, patch)
2022-02-11 05:10 PST, Kimmo Kinnunen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
For EWS (273.64 KB, patch)
2022-02-11 05:15 PST, Kimmo Kinnunen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
For EWS (276.00 KB, patch)
2022-02-11 05:38 PST, Kimmo Kinnunen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
For EWS (276.00 KB, patch)
2022-02-11 05:47 PST, Kimmo Kinnunen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
For EWS (276.47 KB, patch)
2022-02-11 06:37 PST, Kimmo Kinnunen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
For EWS (277.82 KB, patch)
2022-02-11 07:10 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch (279.50 KB, patch)
2022-02-14 01:19 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Show Obsolete (9) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2022-02-11 00:06:44 PST 
ExtensionsGL is not useful class, it should be removed

It ends up just a complicated duplication of what is in GraphicsContextGL. Each contextgl type has  has 1:1 hard-coded mapping to the extensiongl type.

It causes problems because extensionsgl is needed during initialization of contextgl, in order to interact with the extension strings.
This in turn is less-than-simple, since constructors calling virtual functions of the instance being constructed is complicated.
Comment 1 Kimmo Kinnunen 2022-02-11 00:51:20 PST 
Created attachment 451653 [details]
Patch
Comment 2 Kimmo Kinnunen 2022-02-11 04:15:32 PST 
Created attachment 451674 [details]
For EWS
Comment 3 Kimmo Kinnunen 2022-02-11 05:01:34 PST 
Created attachment 451677 [details]
For EWS
Comment 4 Kimmo Kinnunen 2022-02-11 05:10:10 PST 
Created attachment 451678 [details]
For EWS
Comment 5 Kimmo Kinnunen 2022-02-11 05:15:31 PST 
Created attachment 451679 [details]
For EWS
Comment 6 Radar WebKit Bug Importer 2022-02-11 05:26:30 PST 
<rdar://problem/88811001>
Comment 7 Kimmo Kinnunen 2022-02-11 05:38:57 PST 
Created attachment 451680 [details]
For EWS
Comment 8 Kimmo Kinnunen 2022-02-11 05:47:50 PST 
Created attachment 451681 [details]
For EWS
Comment 9 Kimmo Kinnunen 2022-02-11 06:37:51 PST 
Created attachment 451686 [details]
For EWS
Comment 10 Kimmo Kinnunen 2022-02-11 07:10:01 PST 
Created attachment 451690 [details]
For EWS
Comment 11 Kimmo Kinnunen 2022-02-14 01:19:34 PST 
Created attachment 451873 [details]
Patch
Comment 12 EWS 2022-02-14 23:35:36 PST 
Committed r289790 (247255@main): <https://commits.webkit.org/247255@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451873 [details].