WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 236490
ExtensionsGL is not useful class, it should be removed
https://bugs.webkit.org/show_bug.cgi?id=236490
Summary
ExtensionsGL is not useful class, it should be removed
Kimmo Kinnunen
Reported
2022-02-11 00:06:44 PST
ExtensionsGL is not useful class, it should be removed It ends up just a complicated duplication of what is in GraphicsContextGL. Each contextgl type has has 1:1 hard-coded mapping to the extensiongl type. It causes problems because extensionsgl is needed during initialization of contextgl, in order to interact with the extension strings. This in turn is less-than-simple, since constructors calling virtual functions of the instance being constructed is complicated.
Attachments
Patch
(269.62 KB, patch)
2022-02-11 00:51 PST
,
Kimmo Kinnunen
no flags
Details
Formatted Diff
Diff
For EWS
(271.79 KB, patch)
2022-02-11 04:15 PST
,
Kimmo Kinnunen
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
For EWS
(271.82 KB, patch)
2022-02-11 05:01 PST
,
Kimmo Kinnunen
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
For EWS
(272.84 KB, patch)
2022-02-11 05:10 PST
,
Kimmo Kinnunen
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
For EWS
(273.64 KB, patch)
2022-02-11 05:15 PST
,
Kimmo Kinnunen
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
For EWS
(276.00 KB, patch)
2022-02-11 05:38 PST
,
Kimmo Kinnunen
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
For EWS
(276.00 KB, patch)
2022-02-11 05:47 PST
,
Kimmo Kinnunen
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
For EWS
(276.47 KB, patch)
2022-02-11 06:37 PST
,
Kimmo Kinnunen
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
For EWS
(277.82 KB, patch)
2022-02-11 07:10 PST
,
Kimmo Kinnunen
no flags
Details
Formatted Diff
Diff
Patch
(279.50 KB, patch)
2022-02-14 01:19 PST
,
Kimmo Kinnunen
no flags
Details
Formatted Diff
Diff
Show Obsolete
(9)
View All
Add attachment
proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1
2022-02-11 00:51:20 PST
Created
attachment 451653
[details]
Patch
Kimmo Kinnunen
Comment 2
2022-02-11 04:15:32 PST
Created
attachment 451674
[details]
For EWS
Kimmo Kinnunen
Comment 3
2022-02-11 05:01:34 PST
Created
attachment 451677
[details]
For EWS
Kimmo Kinnunen
Comment 4
2022-02-11 05:10:10 PST
Created
attachment 451678
[details]
For EWS
Kimmo Kinnunen
Comment 5
2022-02-11 05:15:31 PST
Created
attachment 451679
[details]
For EWS
Radar WebKit Bug Importer
Comment 6
2022-02-11 05:26:30 PST
<
rdar://problem/88811001
>
Kimmo Kinnunen
Comment 7
2022-02-11 05:38:57 PST
Created
attachment 451680
[details]
For EWS
Kimmo Kinnunen
Comment 8
2022-02-11 05:47:50 PST
Created
attachment 451681
[details]
For EWS
Kimmo Kinnunen
Comment 9
2022-02-11 06:37:51 PST
Created
attachment 451686
[details]
For EWS
Kimmo Kinnunen
Comment 10
2022-02-11 07:10:01 PST
Created
attachment 451690
[details]
For EWS
Kimmo Kinnunen
Comment 11
2022-02-14 01:19:34 PST
Created
attachment 451873
[details]
Patch
EWS
Comment 12
2022-02-14 23:35:36 PST
Committed
r289790
(
247255@main
): <
https://commits.webkit.org/247255@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 451873
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug