Bug 23649 - Update SQLTransactionErrorCallback to not return a value
Summary: Update SQLTransactionErrorCallback to not return a value
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-30 10:29 PST by Dimitri Glazkov (Google)
Modified: 2009-05-26 12:37 PDT (History)
0 users

See Also:


Attachments
v1 submitted for review (12.79 KB, patch)
2009-01-30 10:36 PST, Dimitri Glazkov (Google)
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2009-01-30 10:29:54 PST
This change brings HTML5 Database implementation up to the latest spec, which was changed to always rollback the transaction after the error callback is called.
Comment 1 Dimitri Glazkov (Google) 2009-01-30 10:36:00 PST
Created attachment 27187 [details]
v1 submitted for review

 LayoutTests/ChangeLog                              |   11 ++
 .../transaction-error-callback-expected.txt        |    9 ++
 .../storage/transaction-error-callback.html        |  105 ++++++++++++++++++++
 WebCore/ChangeLog                                  |   20 ++++
 .../js/JSCustomSQLTransactionErrorCallback.cpp     |   11 +--
 .../js/JSCustomSQLTransactionErrorCallback.h       |    2 +-
 WebCore/storage/SQLTransaction.cpp                 |   29 ++----
 WebCore/storage/SQLTransaction.h                   |    1 -
 WebCore/storage/SQLTransactionErrorCallback.h      |    2 +-
 9 files changed, 159 insertions(+), 31 deletions(-)
Comment 2 Dimitri Glazkov (Google) 2009-02-11 16:27:38 PST
Ping?
Comment 3 Maciej Stachowiak 2009-05-22 00:31:10 PDT
Comment on attachment 27187 [details]
v1 submitted for review

r=me
Comment 4 Dimitri Glazkov (Google) 2009-05-26 12:37:46 PDT
Landed as http://trac.webkit.org/changeset/44155.