Bug 236479 - Enable grammar checking on Mac Catalyst.
Summary: Enable grammar checking on Mac Catalyst.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-10 18:46 PST by Megan Gardner
Modified: 2022-02-11 15:05 PST (History)
6 users (show)

See Also:


Attachments
Patch (11.63 KB, patch)
2022-02-10 18:54 PST, Megan Gardner
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (11.63 KB, patch)
2022-02-10 19:26 PST, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch for landing (11.70 KB, patch)
2022-02-11 14:31 PST, Megan Gardner
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2022-02-10 18:46:25 PST
Enable grammar checking on Mac Catalyst.
Comment 1 Megan Gardner 2022-02-10 18:54:22 PST
Created attachment 451627 [details]
Patch
Comment 2 Megan Gardner 2022-02-10 19:26:28 PST
Created attachment 451632 [details]
Patch
Comment 3 Devin Rousso 2022-02-11 12:38:56 PST
Comment on attachment 451632 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451632&action=review

r=mews, nice! :)

> Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm:66
> +

Style: extra whitespace

> Source/WebKit/UIProcess/ios/TextCheckerIOS.mm:254
> +                    ASSERT(detailRangeAsNSValue);
> +                    NSRange detailNSRange = [detailRangeAsNSValue rangeValue];

Style: I'd maybe sprinkle some newlines in here so it's a bit less "wall-of-text"-y 😅

> Source/WebKit/UIProcess/ios/TextCheckerIOS.mm:261
> +                        detail.guesses.append(String(guess));

NIT: Is the `String` necessary?
Comment 4 Megan Gardner 2022-02-11 14:31:37 PST
Created attachment 451745 [details]
Patch for landing
Comment 5 EWS 2022-02-11 15:04:34 PST
Committed r289673 (247161@main): <https://commits.webkit.org/247161@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451745 [details].
Comment 6 Radar WebKit Bug Importer 2022-02-11 15:05:16 PST
<rdar://problem/88837575>