Bug 236460 - tryReserveUncommittedAligned should explicitly take the alignment requested
Summary: tryReserveUncommittedAligned should explicitly take the alignment requested
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-10 12:49 PST by Keith Miller
Modified: 2022-02-10 16:22 PST (History)
10 users (show)

See Also:

Attachments
Patch (9.87 KB, patch)
2022-02-10 13:00 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (9.99 KB, patch)
2022-02-10 13:47 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (9.99 KB, patch)
2022-02-10 13:48 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2022-02-10 12:49:15 PST 
tryReserveUncommittedAligned should explicitly take the alignment requested
Comment 1 Keith Miller 2022-02-10 13:00:06 PST 
Created attachment 451591 [details]
Patch
Comment 2 Yusuke Suzuki 2022-02-10 13:33:47 PST 
Comment on attachment 451591 [details]
Patch

r=me
Comment 3 Keith Miller 2022-02-10 13:34:58 PST 
Comment on attachment 451591 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451591&action=review

> Source/JavaScriptCore/ChangeLog:11
> +        original alignment to the allocator as a new parameter.

Forgot to comment that I added another branch of code for Unix flavors that have the `MAP_ALIGNED` flag. Will add that before landing.
Comment 4 Keith Miller 2022-02-10 13:47:46 PST 
Created attachment 451597 [details]
Patch for landing
Comment 5 Keith Miller 2022-02-10 13:48:14 PST 
Created attachment 451598 [details]
Patch for landing
Comment 6 EWS 2022-02-10 16:21:37 PST 
Committed r289592 (247105@main): <https://commits.webkit.org/247105@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451598 [details].
Comment 7 Radar WebKit Bug Importer 2022-02-10 16:22:16 PST 
<rdar://problem/88784711>