Bug 236456 - Don't throw exception when controls are removed
Summary: Don't throw exception when controls are removed
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrique Ocaña
Keywords: InRadar
Depends on:
Reported: 2022-02-10 11:02 PST by Enrique Ocaña
Modified: 2022-02-14 04:22 PST (History)
9 users (show)

See Also:

Patch (1.71 KB, patch)
2022-02-10 11:08 PST, Enrique Ocaña
no flags Details | Formatted Diff | Diff
Patch (1.72 KB, patch)
2022-02-11 02:58 PST, Enrique Ocaña
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Enrique Ocaña 2022-02-10 11:02:02 PST
In mediaControlsBase.js, when media controls are removed, calling controlsAreHidden() can cause an exception because the panel has no parentElement.
Comment 1 Enrique Ocaña 2022-02-10 11:08:20 PST
Created attachment 451577 [details]
Comment 2 Xabier Rodríguez Calvar 2022-02-10 23:24:01 PST
Comment on attachment 451577 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=451577&action=review

> Source/WebCore/ChangeLog:1
> +2022-02-10  Eugene Mutavchi  <Ievgen_Mutavchi@comcast.com>

You're responsible for this patch, your name should be here. Eugene's one is already in below.

> Source/WebCore/ChangeLog:3
> +        Don't throw exception when controls are hidden

If the crash happens because controls are removed, then this title is misleading.
Comment 3 Enrique Ocaña 2022-02-11 02:58:14 PST
Created attachment 451666 [details]
Comment 4 EWS 2022-02-14 04:21:55 PST
Committed r289730 (247215@main): <https://commits.webkit.org/247215@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451666 [details].
Comment 5 Radar WebKit Bug Importer 2022-02-14 04:22:19 PST