Bug 236453 - [GStreamer][MSE] Let MSE set natural video size when using holepunch
Summary: [GStreamer][MSE] Let MSE set natural video size when using holepunch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrique Ocaña
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-10 10:35 PST by Enrique Ocaña
Modified: 2022-02-15 04:04 PST (History)
14 users (show)

See Also:

Attachments
Patch (2.94 KB, patch)
2022-02-10 10:43 PST, Enrique Ocaña 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrique Ocaña 2022-02-10 10:35:10 PST 
Currently the holepunch implementation completely overrides the video size to a hardcoded value. It would be desirable to let the m_videoSize value set by MediaPlayerPrivateGStreamerMSE::setInitialVideoSize() take precedence over the hardcoded value.
Comment 1 Enrique Ocaña 2022-02-10 10:43:35 PST 
Created attachment 451565 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2022-02-10 23:20:02 PST 
Comment on attachment 451565 [details]
Patch

I'm ok, but let's wait for Miguel, our holepunch expert to give the final green light.
Comment 3 Miguel Gomez 2022-02-14 07:03:14 PST 
(In reply to Xabier Rodríguez Calvar from comment #2)
> Comment on attachment 451565 [details]
> Patch
> 
> I'm ok, but let's wait for Miguel, our holepunch expert to give the final
> green light.

LGTM
Comment 4 EWS 2022-02-15 04:03:12 PST 
Committed r289800 (247265@main): <https://commits.webkit.org/247265@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451565 [details].
Comment 5 Radar WebKit Bug Importer 2022-02-15 04:04:58 PST 
<rdar://problem/88957858>