Bug 236437 - [GTK][WPE] Refactor the XDGDBusProxy launcher to simplify it and fix some issues
Summary: [GTK][WPE] Refactor the XDGDBusProxy launcher to simplify it and fix some issues
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2022-02-10 03:50 PST by Carlos Garcia Campos
Modified: 2022-02-10 05:55 PST (History)
2 users (show)

See Also:

Attachments
Patch (31.77 KB, patch)
2022-02-10 03:55 PST, Carlos Garcia Campos 		aperez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2022-02-10 03:50:54 PST 
I've noticed several issues:

 - r289369 introduced an issue with old versions of bwrap that fails to mount over an existing file, so we need to ensure we only bind the original socket for the a11y socket and not the session bus one.
 - bindA11y is GTK specific for some reason, which means WPE doesn't have a11y under the sandbox.
 - The names of the socket paths for a11y and session bus use the same pattern dbus-proxy-XXXXXX, it helps to use a different one.
 - The code to get the a11y DBus address is now duplicated in PlatformDisplay, we can just use the PlatformDisplay to get the address.
Comment 1 Carlos Garcia Campos 2022-02-10 03:55:55 PST 
Created attachment 451513 [details]
Patch
Comment 2 Adrian Perez 2022-02-10 05:46:20 PST 
Comment on attachment 451513 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451513&action=review

> Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:785
> +    int bwrapFd = argumentsToFileDescriptor(sandboxArgs, "bwrap");

Much better function name, indeed!
Comment 3 Carlos Garcia Campos 2022-02-10 05:55:15 PST 
Committed r289528 (?): <https://commits.webkit.org/r289528>