Bug 236419 – Fail synchronously when constructing a SharedWorker with an URL that is not same-origin

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

Fail synchronously when constructing a SharedWorker with an unsupported protocol.

[Chris Dumez]

Created attachment 451467 [details]
Patch

[Darin Adler]

Comment on attachment 451467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451467&action=review

> LayoutTests/imported/w3c/ChangeLog:16
> +        * web-platform-tests/workers/shared-worker-in-data-url-context.window-expected.txt:
> +        Even though this looks like a regression, this actually aligns our behavior with both
> +        Blink & Gecko (who also fail this check). Note that the load fails no matter what.
> +        However, the test expects it to fail asynchronously instead of synchronously in this
> +        case.

When will we fix WPT?

[Chris Dumez]

(In reply to Darin Adler from comment #2)
> Comment on attachment 451467 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=451467&action=review
> 
> > LayoutTests/imported/w3c/ChangeLog:16
> > +        * web-platform-tests/workers/shared-worker-in-data-url-context.window-expected.txt:
> > +        Even though this looks like a regression, this actually aligns our behavior with both
> > +        Blink & Gecko (who also fail this check). Note that the load fails no matter what.
> > +        However, the test expects it to fail asynchronously instead of synchronously in this
> > +        case.
> 
> When will we fix WPT?

I will follow-up. I think I may need to start a discussion on the spec. Technically, I think the test matches the spec and was written by a Chrome engineer to point out issues with their implementation. However, the test landed over a year ago and Chrome still hasn't updated their implementation to pass the test they added. Since the spec isn't in agreement with browsers it seems, I guess the best way forward is to modify the spec to match Blink & Gecko's implementation.

[EWS]

Committed r289532 (247063@main): <https://commits.webkit.org/247063@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451467 [details].

[Radar WebKit Bug Importer]

<rdar://problem/88753909>